Issue 3958 - Support Word XP inline escher objects
Summary: Support Word XP inline escher objects
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 642
Hardware: PC Windows NT
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: oooqa
: 3281 6578 6643 9028 11787 (view as issue list)
Depends on:
Blocks: 18480 20604
  Show dependency tree
 
Reported: 2002-04-10 20:03 UTC by skiani
Modified: 2013-08-07 14:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Save this files as Word file and open in Word97, the graphics are gone. (5.46 KB, application/octet-stream)
2002-04-10 20:04 UTC, skiani
no flags Details
import ok patch, fails on exporting. (27.25 KB, patch)
2002-09-20 11:28 UTC, caolanm
no flags Details | Diff
Update to SRX644_m source. (24.34 KB, patch)
2002-11-20 14:24 UTC, Unknown
no flags Details | Diff
Import Ok and Export as Zeroed to Char. (11.70 KB, patch)
2003-03-04 15:24 UTC, aidan.butler
no flags Details | Diff
patch that *nearly* does it (66.08 KB, patch)
2003-10-23 16:36 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description skiani 2002-04-10 20:03:08 UTC
Seems that this build is not exporting graphics that are in text drawings.
Comment 1 skiani 2002-04-10 20:04:02 UTC
Created attachment 1354 [details]
Save this files as Word file and open in Word97, the graphics are gone.
Comment 2 Joost Andrae 2002-04-11 16:53:36 UTC
Joost->Michael: please have a look at it...reassigned to you
Comment 3 michael.ruess 2002-04-15 14:06:48 UTC
A certain kind of drawing objects seems to make problems while exporting.
The nonpro also throws an Assert "OutWW8FlyFrm:DrawInCnt-Baustelle".
Generally the export of drawing objects works (also grouped ones), but
in this special case, I don't what's wrong with the object.
Comment 4 skiani 2002-04-15 14:13:49 UTC
It seems to be related to the anchor as charactor option. If you set
the object as anchor to page it exports ok.
Comment 5 caolanm 2002-04-17 09:39:17 UTC
Yes, it was not possible to anchor drawing objects (i.e. escher
objects) inline "as character" in word 2000 and older version. 

In xp there appears to have appeared a mechanism to do it. Sadly I
don't know how this mechanism is working and we can't import this type
of anchoring either :-(

So its a missing XP feature, some sort of field + graphic stuff. I'll
look into it.
Comment 6 skiani 2002-05-01 19:07:41 UTC
Not true! Both Word 97 and 2000 allow you to do this. 

Word 97: If you paste an object in either then right click on the
object and select "format picture". Under the "position" tab turn off
"float over text" switch. This will make the object act like a charactor.

Word 2000: If you paste an object in either then right click on the
object and select "format picture". Under the "Layout" tab tselection
the "In line with text" option. This will make the object act like a
charactor.

I don't have XP to compare.
Comment 7 caolanm 2002-05-07 10:22:29 UTC
Trust me. I said "drawing objects (i.e. escher objects)", there are
the drawing objects like squares, rectanges and textboxes, not the
straight forwards pictures. Insert a text box in 97/2000 and go to
format textbox,  the "in line with text" is grayed out. Similiarly
with a shape you have format autoshape, and in line with text is not
available.

You now have an "in line with text" option with office xp, this is
implemented in terms is a field, which does some tricky business to
achieve an in line with text ability while retaining backwards
compatability.

Comment 8 caolanm 2002-05-10 12:54:30 UTC
*** Issue 3281 has been marked as a duplicate of this issue. ***
Comment 9 caolanm 2002-07-24 15:52:31 UTC
2000/xp has a new field for doing "as character" hack. The result of
the field is 0x1 0x8 where the escher graphic is preceded with an
inline graphic hack to munge the two together. A simple but effective
thing is that the 0x08 is by default anchored "to character" so in
older versions of word it looks close to what is desired. So we'd want
to do that as well when implementing this.
Comment 10 caolanm 2002-07-26 09:28:19 UTC
*** Issue 6578 has been marked as a duplicate of this issue. ***
Comment 11 caolanm 2002-08-29 15:20:42 UTC
Its 0x8 before 0x1 not 0x1 0x8, hmm think we should be able to handle
this without too much effort after all. Import anyhow should be
straightforward.
Comment 12 caolanm 2002-09-20 11:28:11 UTC
Created attachment 2914 [details]
import ok patch, fails on exporting.
Comment 13 caolanm 2002-11-18 15:45:05 UTC
*** Issue 9028 has been marked as a duplicate of this issue. ***
Comment 14 Unknown 2002-11-20 14:24:22 UTC
Created attachment 3681 [details]
Update to SRX644_m source.
Comment 15 Unknown 2002-11-20 14:25:13 UTC
In m patch, modified import to make sure vertical alignment matches 
that used by Word.
Comment 16 caolanm 2002-12-09 10:36:07 UTC
We'll see if we can get this implemented fully.
Comment 17 caolanm 2003-02-07 13:28:33 UTC
*** Issue 6643 has been marked as a duplicate of this issue. ***
Comment 18 aidan.butler 2003-03-04 15:24:06 UTC
Created attachment 4974 [details]
Import Ok and Export as Zeroed to Char.
Comment 19 caolanm 2003-03-06 16:40:56 UTC
cmc->aidan: issue 11787 is a real world import example of this inline. 
There is a possible additional glitch of a drawing canvas in use.
Comment 20 caolanm 2003-03-06 16:41:18 UTC
*** Issue 11787 has been marked as a duplicate of this issue. ***
Comment 21 aidan.butler 2003-04-10 16:29:19 UTC
aidan: Following discussion with Caolan and mru, retargetting export
implementation for 2.0. 
Comment 22 aidan.butler 2003-06-20 14:31:38 UTC
Aidan -> cmc: Sending this back to you
Comment 23 caolanm 2003-07-03 12:51:17 UTC
Accept, looks like I'll just have to do it myself.
Comment 24 caolanm 2003-09-17 17:52:05 UTC
cmc->sj: This relates to how word uses the "canvas", do you any
information about the canvas. Is powerpoint/impress using/importing
this thing.
Comment 25 sven.jacobi 2003-09-18 11:18:04 UTC
In the file format a canvas is stored as group object, but there are
some extra atoms used for a canvas: an fbtUDefProp atom and an
fbtClientData atom, the client atom seems to contain the data that
makes a canvas, but this data is application dependent.

In PPT files there is something that is working similar to the canvas
in Word, just insert a Organization Chart (Therefore I already have
Issue 14375)
Comment 26 caolanm 2003-10-23 16:36:08 UTC
Created attachment 10588 [details]
patch that *nearly* does it
Comment 27 caolanm 2003-10-23 16:36:49 UTC
I can nearly do this, attached patch works, but it needs to be inside
a SHAPE field, which currently crashes word. But very close indeed.
Comment 28 caolanm 2003-10-24 17:42:51 UTC
My god, this was insane to implemented, a 12 coffee cup problem.

A 0x08 escher object followed by a dummy 0x01 inline element which
itself is an escher picture frame all inside a shape field, and with a
magic property attached to the 0x08 and the 0x01 objects which must match.

All done in portlaoisefilterteam16 for 2.0
Comment 29 caolanm 2003-11-07 15:54:21 UTC
reopen to reassign to qa.
Comment 30 caolanm 2003-11-07 15:55:04 UTC
cmc->mru: Good in Fri-Nov-07-16-00 portlaoisefilterteam16 installset,
a most difficult but excellent feature to support. Give it a good
thumping.
Comment 31 michael.ruess 2003-11-25 12:04:50 UTC
MRU->CMC: for Word 2003 it looks good. please also add support for
Word XP inline eschers. Seems to be kind of different in that format.
Comment 32 caolanm 2003-11-27 12:35:06 UTC
Incredible!, you *also* need to have
1) fAnchorLock set on the escher objects word FSPA structure to make
it work in WordXP, though its not needed in 2003 and
2) Need to correctly set fHasSep for the Field Descriptor that
surrounds the shape to make it word in 2000, though this is not needed
in XP and 2003.

A most mysterious set of shifting requirements, if we needed more
requirements with newer versions I would suspect deliberate
obstruction, but it gets easier to do as the version of word get more
recent.

So, extra requirements checked into portlaoisefilterteam16.
Comment 33 caolanm 2003-11-27 13:29:11 UTC
reopen to reassign
Comment 34 caolanm 2003-11-27 13:34:29 UTC
cmc->mru: New changes seem to make this work in portlaoise for XP and
2000 now.
Comment 35 michael.ruess 2003-12-03 11:33:38 UTC
Yes, now also looks great with WordXP. Checked with CWS
portlaoisefilterteam16.
Comment 36 michael.ruess 2003-12-03 11:34:21 UTC
Verified. Fix will be part of OO 2.0.
Comment 37 michael.ruess 2004-03-25 14:50:11 UTC
Checked integration in 680m30.