Issue 78702 - Move #define UNICODE to makefile.mk - followup
Summary: Move #define UNICODE to makefile.mk - followup
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Windows, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-20 13:41 UTC by hjs
Modified: 2017-05-20 10:47 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
occurances of UNICODE in sources (2.46 KB, text/plain)
2007-06-20 13:51 UTC, hjs 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hjs 2007-06-20 13:41:39 UTC 
followup issue to #i77339# dealing with non-trivial places
Comment 1 hjs 2007-06-20 13:51:02 UTC 
Created attachment 46095 [details]
occurances of UNICODE in sources
Comment 2 hennes.rohling 2007-07-12 12:24:43 UTC 
Accept
Comment 3 hennes.rohling 2007-08-01 10:11:12 UTC 
.
Comment 4 kai.sommerfeld 2007-12-12 09:38:31 UTC 
.
Comment 5 hennes.rohling 2008-05-30 13:51:58 UTC 
Retargeted.
Comment 6 Mathias_Bauer 2009-04-09 13:35:49 UTC 
As this is a potential breakage for any code, we should see if it is possible to
*always* use UNICODE/_UNICODE defined so that this define can be moved to the
global mk file and PCH works again for all these files. This will comprise
removing the define from all makefile.mk where we have added it for issue 77339.

We also should change the code to use explicit typing (e.g. char or wchar
instead of _TCHAR).

Unfortunately it won't suffice to just compile the code, it's possible that a
mix of explicit and wrapped typing in some code can lead to crashes or other
bugs if it formerly was compiled without /DUNICODE.
Comment 7 Marcus 2017-05-20 10:47:55 UTC 
Reset assigne to the default "issues@openoffice.apache.org".