Issue 77339 - Move #define UNICODE to makefile.mk
Summary: Move #define UNICODE to makefile.mk
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m209
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: hjs
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-14 10:23 UTC by hennes.rohling
Modified: 2007-07-13 14:17 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hennes.rohling 2007-05-14 10:23:54 UTC 
In desktop/source/win32/applauncher the following files contain a preprocessor
direktive #define UNICODE before #include <windows.h>

launcher.cxx
scalc.cxx
swriter.cxx
simpres.cxx
smath.cxx
sdraw.cxx
sbase.cxx

This may break precompiled header functionality.
Comment 1 hjs 2007-05-14 10:53:18 UTC 
you mean "desktop/win32/source/applauncher"?
looks like an easy one as all sources there seem to use this define. setting in
the makefile should do...
Comment 2 hjs 2007-05-16 11:14:00 UTC 
what about dtrans/source/win32/mtaole/MtaOleClipb.cxx ?
Comment 3 hjs 2007-06-11 16:20:45 UTC 
these two places are changed now. looking for more...
Comment 4 hjs 2007-06-20 13:53:51 UTC 
changed the two places mentioned here. followup #i78702# to care for the remaining
Comment 5 rt 2007-06-26 13:52:42 UTC 
Verified on CWS ause079.
Comment 6 hjs 2007-07-13 14:17:41 UTC 
.