Issue 6191 - Right-click accept / reject changes
Summary: Right-click accept / reject changes
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial with 29 votes (vote)
Target Milestone: ---
Assignee: Oliver Specht
QA Contact: issues@sw
URL:
Keywords: ms_interoperability, oooqa
: 27221 58840 64546 84059 (view as issue list)
Depends on:
Blocks:
 
Reported: 2002-06-28 00:52 UTC by lorrin
Modified: 2013-08-07 14:43 UTC (History)
12 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Spec, first revision (72.68 KB, application/vnd.oasis.opendocument.text)
2008-11-06 15:02 UTC, Oliver Specht
no flags Details
simple patch to add seperator (793 bytes, text/plain)
2009-01-14 00:31 UTC, max.odendahl
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description lorrin 2002-06-28 00:52:24 UTC
It would be great if it was possible to accept/reject changes by right clicking
on them instead of going through the "accept or reject changes" dialog
Comment 1 stefan.baltzer 2003-06-04 14:16:16 UTC
Reassigned to Bettina.
Comment 2 Rainer Bielefeld 2003-06-18 08:40:49 UTC
I think it is a nice idea, but it might cause a lot of work to add
this feature?

I think importance is not more than P5

Rainer
Comment 3 Rainer Bielefeld 2003-06-18 08:43:51 UTC
I do not think that that will be so easy - how can yo click on a
deleted paragraph to reject the change? The dialogue still will be
required, and the only advantage could be, that the change will be
marked in the dialoge in accordance to the area where you rightclicked.

Rainer
Comment 4 lorrin 2003-06-18 20:43:48 UTC
Spellcheck is a good example. Right now, when a word is misspelled,
you can right-click and quickly add the word to your dictionary or
chose to ignore it. This is quick and easy and requires only one mouse
click. If your only option were to run the spell check on the whole
document and step through until you got back to the word that you were
looking at, it would be horribly tedious.


The situation with accept/reject changes is similar to spell checking
without a right-click option. The dialog is so big you can't see what
you're working on, and it is very difficult to find the change you
want in the enormous list of revisions. Much more convenient would be
to just click on the change on your screen, move over to reject or
accept, let go of the mouse button and be done.
Comment 5 utomo99 2003-10-08 04:21:42 UTC
we need to consider the suggestion if not so difficult
Comment 6 guido.pinkernell 2004-02-08 11:40:29 UTC
Set to New to have it off the unconfirmed issues list.
Comment 7 gilshwartz 2004-03-01 19:05:50 UTC
Even if implementing this may be difficult for some extreme cases, the common 
case of clearly marked changed words should provide the most cost effective 
solution and answer most of the need.
Comment 8 absolution 2005-03-08 02:40:15 UTC
I consider this issue a little more important. If there is a lot of changes in
the huge document it's very difficult to handle rejecting or accepting changes.
Recently I had to switch to Word 97, because of inconvenient revision handling
in OO.

Accepting or rejecting on right click is good idea. I also propose, that if
cursor is pointed on the changed text, contexting line in "Accept or Reject
Changes" dialog will be selected. This enhancment will help greatly.

I found also disturbing, that after pressing Accept or Reject in this dialog,
document scrolls on the place, where the next change is located - sometimes many
pages is scrolled by surprise and it takes time to get in touch with the text
again. I understand this was intended to help, but in many cases it confuses a lot.

Also the "Revision toolbar" with buttons for accept, reject, previous and next
will be definitely welcome.
Comment 9 michael.ruess 2005-12-06 10:38:42 UTC
*** Issue 58840 has been marked as a duplicate of this issue. ***
Comment 10 michael.ruess 2006-04-20 11:46:47 UTC
*** Issue 64546 has been marked as a duplicate of this issue. ***
Comment 11 simono 2006-12-12 09:45:01 UTC
As the editor of a big document with several contributers, I can say that this
feature would save me a lot of problems. Also, I've had several crashes when
accepting a deletion from the dialogue. 

In addition, it would be useful to have a marker to click for each
deletion/insertion, either in the margin of the document or at the start/end of
each insertion or deletion block. Clicking on this should give options to accept
or reject and it may also be linked to the changes dialogue. Currently (2.0.4
linux) this is not possible, I have trouble finding the right line to accept or
reject from a page of text. This leaves me only the option to accept/reject all
changes, which is very primitive.
Comment 12 stp 2007-03-17 23:46:45 UTC
*** Issue 27221 has been marked as a duplicate of this issue. ***
Comment 13 myk_taylor 2007-09-04 00:00:23 UTC
The absence of this feature makes "Track Changes" very unwieldy.  I've added my
votes for this issue.

On another note, I think it would be appropriate to change the OS specification
for this issue to "All" and to update the Version field to the most recent OO
version.  As of 2.2.1 it still has not been implemented.
Comment 14 gtimur 2007-09-20 11:59:43 UTC
I'd be glad to add some more points for this, but I don't have any more. It
definitely deserves better priority than P5. The whole revision system in
OpenOffice should be improved. This issue is 5 years old, from version 1.0.0....
I don't think it's too complicated, like "lorrin" pointed out.
Comment 15 bettina.haberer 2007-09-26 16:01:09 UTC
Hi Mathias, I have changed the current owner to your owner. Please take the
ownership of these enhancements.
Comment 16 milek_pl 2007-10-06 20:41:15 UTC
adding keyword, as most MS Office users expect this feature to be in the Writer
Comment 17 michael.ruess 2007-11-28 21:13:01 UTC
*** Issue 84059 has been marked as a duplicate of this issue. ***
Comment 18 venkumara 2007-12-31 10:47:37 UTC
I too think this is important. I've given 2 votes. I fully agree that the dialog
box is too large and blocking much of the screen space. Furthermore, I can't
make it much smaller, to provide ample viewing space.

As a short term measure, can the developers please consider making the dialog
box flexible in size? IOW, allow users to make the dialog box as small as they
like. Thank you so very much!

venkumara
Comment 19 gtimur 2008-05-20 07:57:55 UTC
I don't see any change in OO 3 beta, unfortunately. 
Comment 20 Oliver Specht 2008-07-24 07:16:23 UTC
Target set to 3.1 and Priority changed.
Comment 21 Oliver Specht 2008-07-24 07:21:08 UTC
Dependency to issue 57288 removed.
Comment 22 xagia 2008-08-14 12:10:44 UTC
As we are actually editing a book, I too experienced the manner of
accepting/rejecting changes as too unhandy in the case of having a lot (really a
lot) of changes. I think the right click would help.
Comment 23 max.odendahl 2008-08-28 11:10:16 UTC
mod->os: as 3.1 will have Changes-Comments as notes in the margin as well, it
might make sense to put "Comment" into the popup as well
Comment 24 Oliver Specht 2008-11-06 15:02:21 UTC
Created attachment 57740 [details]
Spec, first revision
Comment 25 Oliver Specht 2008-11-06 15:10:24 UTC
->ufi,mru,fl: Please have a look at the highly sophisticated spec.

commited in cws os121 in 
sw/inc/cmdid.h
sw/sdi/swriter.sdi
sw/sdi/_viewsh.sdi
sw/source/ui/uiview/viewstat.cxx
sw/source/ui/uiview/view2.cxx
sw/source/ui/inc/swmn_tmpl.hrc
Comment 26 Oliver Specht 2008-11-13 09:05:36 UTC
Spec is now available on
http://specs.openoffice.org/writer/menus/AcceptRejectChange.odt
Comment 27 Oliver Specht 2008-11-13 13:21:39 UTC
Reassigned for verification
Comment 28 michael.ruess 2008-11-24 15:33:25 UTC
Verified in CWS os121.
Comment 29 michael.ruess 2009-01-09 10:34:21 UTC
Checked in DEV300m38 (OOo 3.1 dev build).
Comment 30 max.odendahl 2009-01-14 00:30:19 UTC
mod->os: wouldn't an additional seperator after Reject Change look a lot better? 

-------
Accept
Reject
-------
Edit Paragraph Style
Comment 31 max.odendahl 2009-01-14 00:31:05 UTC
simple patch
Comment 32 max.odendahl 2009-01-14 00:31:58 UTC
Created attachment 59372 [details]
simple patch to add seperator
Comment 33 Oliver Specht 2009-01-14 07:05:39 UTC
->mod: It might make sense to have an additional separator but it doesn't make
sense to reopen issues that are already integrated. 
So I set this one back to verified and close it. Please create a new issue for
the patch.
Comment 34 Oliver Specht 2009-01-14 07:06:09 UTC
verified, again
Comment 35 Oliver Specht 2009-01-14 07:06:27 UTC
closing