Issue 5635 - OOO_STABLE_1/X11+Aqua: unzip should have OO638C_MacOSX unzip patch
Summary: OOO_STABLE_1/X11+Aqua: unzip should have OO638C_MacOSX unzip patch
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ed
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 2588
  Show dependency tree
 
Reported: 2002-06-07 07:40 UTC by fa
Modified: 2004-03-25 04:29 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd to SRC_ROOT/unzip, patch -p0 < /path/to/patchfile (740 bytes, patch)
2002-06-07 07:41 UTC, fa 		no flags Details | Diff
cd to SRC_ROOT/unzip, patch -p0 < /path/to/patchfile This is a diff against CVS from 6/11/02 10PM CST (714 bytes, patch)
2002-06-12 03:56 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2002-06-07 07:40:39 UTC 
To correct the multiple definition problem with inflate().
Comment 1 fa 2002-06-07 07:41:15 UTC 
Created attachment 1888 [details]
cd to SRC_ROOT/unzip, patch -p0 < /path/to/patchfile
Comment 2 fa 2002-06-12 03:56:24 UTC 
Created attachment 1926 [details]
cd to SRC_ROOT/unzip, patch -p0 < /path/to/patchfile   This is a diff against CVS from 6/11/02 10PM CST
Comment 3 khendricks 2002-07-22 20:43:50 UTC 
Hi, 
 
This will impact MacOSX only and so is approved.  But where is the 
system zip library being pulled in to create that synbol conflict? 
 
Could this indicate a bug somewhere else in the build that allows 
the wrong zip library to be linked in someplace (a libz.a from 
system versus a libz.a built in OOo). 
 
I have the same system livel zip libraries but I do not get a 
similar error. 
 
Please double check that this is not indicative of another problem 
before commiting this. 
 
Thanks, 
 
Kevin
Comment 4 fa 2002-07-22 20:48:08 UTC 
Kevin,

We have to link with "-framework System" which already pulls in zip 
libraries, and therefore the collision.  There is *no* way we can NOT 
link against System.framework as it it required to also bring in libc 
and all other system libraries required for linkage.  Unfortunately 
it brings in zip libraries too.

Were the another way to get around this, we should do this, but at 
this time the patch works correctly.

Dan
Comment 5 ed 2002-08-11 20:03:56 UTC 
The changes from this issue were incorporated into the PORTS branch with the commit for Issue 6084 whose patch included these patches.
Comment 6 Martin Hollmichel 2004-03-25 04:29:10 UTC 
close issue.