Issue 4934 - Aqua VCL svtools doesn't build due to missing includes path
Summary: Aqua VCL svtools doesn't build due to missing includes path
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ed
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 2588
  Show dependency tree
 
Reported: 2002-05-16 05:43 UTC by fa
Modified: 2007-02-05 03:28 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Adds the $(PRJ)$/$(GUI)/inc path to the CC include path (369 bytes, patch)
2002-05-16 05:45 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2002-05-16 05:43:22 UTC 
An Aqua VCL build of the OO638C_MacOSX branch will fail with svtools/unx/source/filter/impflt.cxx because the included file impflt.hxx is not found.  settings.mk automatically includes the $(PRJ)$/$(GUIBASE)$/inc path, but of the Aqua VCL build GUIBASE is "aqua".  Therefore, all files are compiled with -I../../../aqua/inc.  The impflt.hxx file however is in ../../../unx/inc and so is not found.  settings.mk does not reliably deal with the presence of two different GUIBASEs on the same GUI platform.

The solution in the short run is to add $(PRJ)$/$(GUI)$/inc to the compile-time CC include path options.  This is best done in solenv/inc/unxmacxp.mk.  Patch attached.
Comment 1 fa 2002-05-16 05:45:35 UTC 
Created attachment 1671 [details]
Adds the $(PRJ)$/$(GUI)/inc path to the CC include path
Comment 2 fa 2002-05-16 05:49:56 UTC 
Sorry...  Solution is to insert INCGUI+= -I$(PRJ)$/unx/inc into unxmacxp.mk, which adds this path to the INCGUI path from settings.mk and allows the files in unx/inc directories to be picked up.
Comment 3 ed 2002-05-17 11:49:33 UTC 
Committed this makefile patch to the OO638C_MacOSX branch.  
This may eventually be replaed by a more clever solution if we 
can figure out how to get the build system and directory structure 
to happily support multiple GUIBASEs for a single platform 
without manually copying and synchronizing two directories.  Ah, 
sometimes how I wish CVS would properly handle symlinks :)
Comment 4 jjmckenzie 2007-02-05 03:28:59 UTC 
Closing issue.  Branch closed a long time ago.

James McKenzie