Issue 19279 - Setup quits on startup in localized installset
Summary: Setup quits on startup in localized installset
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC4
Hardware: Other Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: hjs
QA Contact: issues@installation
URL:
Keywords:
Depends on: 20190
Blocks:
  Show dependency tree
 
Reported: 2003-09-08 18:22 UTC by pezz
Modified: 2004-02-19 18:49 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
generated setup.ins file for OOo-1.1rc4 language 77 (433.15 KB, text/plain)
2003-09-10 17:20 UTC, pezz
no flags Details
Add support for language ID 77 into readlicense_oo (779 bytes, patch)
2003-09-10 17:23 UTC, pezz
no flags Details | Diff
Add support for language ID 77 into scp (1.59 KB, patch)
2003-09-10 17:28 UTC, pezz
no flags Details | Diff
unified patch (1.86 KB, patch)
2003-09-12 07:22 UTC, pezz
no flags Details | Diff
unified patch (4.81 KB, patch)
2003-09-12 07:22 UTC, pezz
no flags Details | Diff
unified patch: fix ID 77 in resmgr.cxx (776 bytes, patch)
2003-09-16 19:25 UTC, pezz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pezz 2003-09-08 18:22:21 UTC
Hi,  
 
I have a following problem: 
I created new language ID 77 for language Estonian and by now those patches 
are added into OOo source. Now I try to create installset using ID 77. 
Installset is created correctly, but it doesn't run properly. After starting 
it displays file unpacking progressbar and when progress reaches the end setup 
quits with no messages. Problem is that setup quits instead of showing first 
setup window and makes installset useless. I've searched, but I've not found 
any useful help on how to debug setup actions and find the problem.  
 
Checked the list of required actions needed to add new language ID and found 
that files basic.scp and unxbasic.scp where both missing 2 lines: 
 
Case 77                        		
SetDefaultModuleByID("gid_Module_Optional_Language_Estonian", True) 
 
but after fixing this nothing changed better, so by web document everything is 
correct. 
 
Setup can be generated by setting RES_ESTONIAN to TRUE. 
 
I can put up generated installset and do any debugging if someone gives me 
some useful hints. 
 
--  
Peeter, 
OpenOffice ET team coordinator
Comment 1 Olaf Felka 2003-09-09 08:33:30 UTC
Hi Martin,
can you help him out?
Comment 2 Martin Hollmichel 2003-09-09 09:36:08 UTC
mh->ause: I think there's somewhere a list with all the changes which
have to be done with a l10n ?
Comment 3 pezz 2003-09-09 12:28:24 UTC
As I wrote, I already checked all the points on page  
http://l10n.openoffice.org/adding_language.html  
  
Step 7 things are missing from official source, because earlier  
version of this document didn't mention these, but after adding  
missing bits nothing changed. I've seen the same behavior since  
1.0.1.  
 
I don't want to start digging OOo codebase, because it's so  
huge and complex, but I could do some debugging if someone could  
give me some hints about how I could trace actions that are taking  
place or see some debuginfo so I could start searching for culprit. 
 
--  
Peeter 
 
Comment 4 ingo.schmidt-rosbiegal 2003-09-10 13:20:35 UTC
Hi Peeter,

this sounds like a problem of an incomplete installation set. This
might be caused by errors in the installation script, which is created
inside the scp project. When packaging the OpenOffice.org in the
project instsetoo you find in the directory misc a file lzip.log. Is
there an error description in this file? Otherwise I would like to
take a look at your setup.inf (for Windows) respectively seutp.ins
(Unix) file, which is located in your installation set. 
Comment 5 pezz 2003-09-10 17:18:28 UTC
Hi Ingo, 
 
Checked lzip.log file and noticed that README77, LICENSE77 etc files 
were not created for ID 77, so I patched readlicense_oo/prj/d.lst. 
It wasn't described in adding_language.html. I'll upload the patch. 
Also to get rid of _every_ error mentioned in lzip.log I copied 
several files into corresponding files (like schart01.zip into 
schart77.zip). Now lzip.log contains no errors but still nothing got 
better. I'll upload setup.ins so you could check it. 
 
btw, I'm compiling on SuSE Linux 8.0 with gcc-3.3. 
 
Comment 6 pezz 2003-09-10 17:20:55 UTC
Created attachment 9179 [details]
generated setup.ins file for OOo-1.1rc4 language 77
Comment 7 pezz 2003-09-10 17:23:23 UTC
Created attachment 9180 [details]
Add support for language ID 77 into readlicense_oo
Comment 8 pezz 2003-09-10 17:28:51 UTC
Created attachment 9181 [details]
Add support for language ID 77 into scp
Comment 9 ingo.schmidt-rosbiegal 2003-09-11 10:57:48 UTC
Hi Peeter,

your installation set is absolutely correct. All files that are needed
by the setup, are included into the installation set. The problems you
described with readme and help files would never cause your
installation problem. But now you even fixed this little problem. 
Concerning to your problem description you start the loader (the file
setup in your installation set), who copies all files needed by the
setup into a temp-directory and starts the setup.bin file (the "real"
setup). It seems as if the loader works without problems and copies
all needed files into the temp directory. Please make the following test:
Start the setup with the parameter "-DONTDELETETEMP". Then you find
the complete temp directory, in which you can start the setup.bin
directly. And then you can get some better error information. And with
this error information, Dirk (I set him on CC) can tell you more about
your problem hopefully.
Comment 10 Martin Hollmichel 2003-09-12 06:54:15 UTC
confirmed.
Comment 11 pezz 2003-09-12 07:22:00 UTC
Created attachment 9228 [details]
unified patch
Comment 12 pezz 2003-09-12 07:22:36 UTC
Created attachment 9229 [details]
unified patch
Comment 13 pezz 2003-09-13 17:53:28 UTC
Hi Ingo, 
 
I think I found the problem. I ran setup.bin from saved temp directory 
through strace and noticed that setup tries to open resource files 
set645XX.res and set_pp1645XX.res, but fails as it tries many other 
languages, but not ID 77. When I copied set64577.res to set64501.res 
setup.bin started up and setup window appeared. Dialog seems to be 
messed up, but at least smth works now. 
 
Looks like it's another bit missing from adding_language.html, 
question is: what is missing? 
 
I uploaded packed sv001.tmp into http://pezz.tkwcy.ee/setuptmp-et.tgz 
if you would like to investigate it. 
 
Comment 14 dirk.voelzke 2003-09-16 08:40:18 UTC
Hi Peeter,

it looks like the estonian language isn't supported by our resource
loading system ( have a look into your version of
tools/source/rc/resmg.cxx and look for '77' and LANGUAGE_ESTONIAN ).
As long as the resource manager doesn't know your langaguge, no
resources can be loaded. If you already added estonian to the function
GetLang(), please check if you added the language to
SearchCreateResMgr(), too. We have to update the 'Adding a New
Language to the Office Suite' guide i think.
Comment 15 pezz 2003-09-16 19:23:23 UTC
Hi Dirk,

thank you very much. After fixing resmgr.cxx (I should have been more 
careful) I'm able to build and run ID 77 installset successfully. I'll 
upload last patch too. To me problem is solved, but I think issue must 
stay open until patches get applied into source.
Comment 16 pezz 2003-09-16 19:25:19 UTC
Created attachment 9389 [details]
unified patch: fix ID 77 in resmgr.cxx
Comment 17 hjs 2003-09-19 17:57:17 UTC
added missing parts to documentation.
Comment 18 ooo 2003-10-06 11:31:41 UTC
The resmgr.cxx patch is covered by issue 20190.
Comment 19 hjs 2003-10-09 12:47:43 UTC
applied patches for "scp" and "readlicense_oo" to "ooo111fix1"
Comment 20 hjs 2004-02-19 18:49:43 UTC
.