Apache OpenOffice (AOO) Bugzilla – Issue 19214
1.1: Printing/font changes from PORTS
Last modified: 2004-10-15 15:11:31 UTC
Patches attached apply the PORTS printing and font features specific to Mac OS X to a checkout of 1.1RC4. There are still lots of problems, as these patches haven't really been updated for 1.1, but simply apply the changes from PORTS. For example: 1) ghostscript 7.x doesn't want to work with Apple Chancery (perhaps others) when printing to PDF converter (NOT File->Export to PDF, but through the Print dialog). It core dumps. 2) Export to PDF doesn't work either with Apple Chancery (perhaps others too), just gives a blank PDF 3) psprint does not correctly find the CUPS printer PPDs for printers and falls back to SGENPRT What _does_ work: 1) Font antialiasing and kerning of Apple fonts (both type 0 and type 2 kerning) I have not tested printing at this time at all.
Created attachment 9073 [details] cd psprint, patch -p0 < /path/to/patchfile
Created attachment 9074 [details] cd vcl, patch -p0 < /path/to/patchfile
Hi, do you think that this patches cold solve the issue 19030, or at least, is 19030 reated to the problems Dan points out? I would like to be sure wether the 19030 is related to code or to my build.. Bye, and thanks Ricky
Hi, Issue 19030 is only somewhat related to problems here, but it is NOT solved by the patches here. The PDF export code is actually completely separate from the psprint PostScript generation code (ie the old Print to PostScript stuff which then gets run through GhostScript to create a PDF). So these patches don't impact Export->PDF. However, this is something that will need to be dealt with anyway. I suggest that tracking of the Export->PDF bug be dealt with in Issue 19030 . Dan
Created attachment 10006 [details] cd psprint, patch -p0 < /path/to/patchfile
Created attachment 10007 [details] cd vcl, patch -p0 < /path/to/patchfile
Revised patches for 1.1 final: psprint.11update.100403.patch vcl.11update.100403.patch These patches make sure printing actually works. Dan
Created attachment 10009 [details] cd psprint, patch -p0 < /path/to/patchfile SUPERCEDES previous psprint 100403 patch
The two patches to use to patch 1.1.0 are: psprint.11update.100403-2.patch vcl.11update.100403.patch
Could someone review before applying to the 1.1.1 cws.
I thought the PORTS syncup patches were going to go through the rcmac cws, seems the plan chnaged? At any rate, Dan mailed dev@porting asking for the pacth to be reviewed before application.
Hi, Please clarify why the updated version of these patches that were previously approved for the PORTS tree need to be approved once again? The rules used to be - anything previously approved for an older tree did not have to be re-reviewed for a newer tree. Furthermore, why for previously reviewed or proven patches (such as from the PORTS tree which was cross-built on other platforms) do we have to wait for reviews just to get changes into a "child workspace" (and that is what the entire OOo trees are). In general, we really need to free up this process for "trusted" independent developers. Dan will not knowingly break anything any more than I or anyone else that has been volunteering their time over the last 2 to 3 years would. Basically, he (and others like Ken, and Volker and etc) have proven that they can be trusted and we should start to relax the way-too-tight rules on tree commits now ... So unless we can guarantee timely reviews (and history has shown we can't ... I try my best but I just don't have the time to review all of the patches from independent developers and I am sure neither do others), why not use the "trust" model and open the process up a bit more. Especially, given the cross-platform tinderbox builds and the cws concept now employed by Hamburg, why not free this issue up and let's stop taking literally years to get patches into the trees. Kevin
Sander, Sorry, completely forgot what I had said about 11rcmac. Did we get rcmac synced with rc4 or rc5? If so, then we can commit 1.1 patches to rc mac and then let the resync happen before 1.1.1 gets out. AFAIK, these two patches here and perhaps 1 or 2 more will be all that needs to happen for 1.1.x on OS X. Dan
its ok 8-) 11rcmac is synced up to rc5 / m19 (the leatest there is) we can do more resyncs as needed (and when there are more milestones), and then merge the macosx chnages to 1.1 master when ready / qa-d. It also shifts review out of critical path
Hi Sander, has it really been synced to m19? According to our internal tooling base milestone for ooo11rcmac is still m13s2 ... Rüdiger
Sander/Ruediger Timm Can we get 11rcmac synced up to RC5? Dan
Created attachment 11077 [details] cd psprint, patch -p0 < /path/to/patchfile Corrects job name switch for both lp and lpr
psprint.jobname.patch psprint.11update.100403-2.patch vcl.11update.100403.patch committed to cws_srx645_ooo11rcmac
close issue.