Issue 19098 - C++ forbids no type - IsAsciiDigit - IsAsciiAlpha
Summary: C++ forbids no type - IsAsciiDigit - IsAsciiAlpha
Status: CLOSED NOT_AN_OOO_ISSUE
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC3
Hardware: Sun Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ooo
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 18988
  Show dependency tree
 
Reported: 2003-09-05 05:41 UTC by sparcmoz
Modified: 2003-12-22 05:28 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description sparcmoz 2003-09-05 05:41:30 UTC 
I hope this is right - i make an issue for each thing and assign it to you.

/usr/local/oo_src/sc/source/ui/docshell/docsh8.cxx:458:
warning: ISO C++ forbids declaration of `IsAsciiDigit' with no type
                                                                                
/usr/local/oo_src/sc/source/ui/docshell/docsh8.cxx:463:
warning: ISO C++ forbids declaration of `IsAsciiAlpha' with no type


Index: sc/source/ui/docshell/docsh8.cxx
===================================================================
RCS file: /cvs/sc/sc/source/ui/docshell/docsh8.cxx,v
retrieving revision 1.15
diff -u -r1.15 docsh8.cxx
--- sc/source/ui/docshell/docsh8.cxx    5 Oct 2001 17:41:05 -0000       1.15
+++ sc/source/ui/docshell/docsh8.cxx    2 Sep 2003 21:54:06 -0000
@@ -454,12 +454,12 @@
                                                                               
                
 // -----------------------------------------------------------------------
                                                                               
                
-inline IsAsciiDigit( sal_Unicode c )
+inline BOOL IsAsciiDigit( sal_Unicode c )
 {
        return 0x31 <= c && c <= 0x39;
 }
                                                                               
                
-inline IsAsciiAlpha( sal_Unicode c )
+inline BOOL IsAsciiAlpha( sal_Unicode c )
 {
        return (0x41 <= c && c <= 0x5a) || (0x61 <= c && c <= 0x7a);
 }
Comment 1 sparcmoz 2003-09-05 05:43:17 UTC 
set target and depends
Comment 2 ooo 2003-09-05 13:18:30 UTC 
Sparcmoz,

No, please don't create separate issues for every Calc relevant "type
information" thingy, attach the patches to issue 18988 instead,
otherwise I'd just drown in OOo1.1.1 issues..

I'll move all patches to issue 18988 and close the originating issues.

Btw: please attach patches instead of copying them into the
description field, where they might get reformatted, lose spaces, or
may otherwise be broken, at the latest when pasting them to a file. It
costs me more work to recreate the patches than to patch the files
themselfs. Thanks.
Comment 3 ooo 2003-09-05 13:19:00 UTC 
closing
Comment 4 utomo99 2003-12-22 05:28:44 UTC 
Removing target from invalid Issue, to reduce the statistics.