Apache OpenOffice (AOO) Bugzilla – Issue 18988
spreadsheet functions with no type - from linux sparc port
Last modified: 2013-08-07 15:13:02 UTC
This issue is to manage those spreadsheet functions with no types - a separate issue shall be made for each case and this issue is to depend on all those. Attached are: (a) a list of the warning messages from gcc-3.3.2 (debian/unstable) on linux sparc (b) my diff against rc4 for module sc I did guess the types and compiled sc, everything in Calc seems much faster now especially open and close spreadsheets, i dont know if this should be expected, or perhaps something else has changed in rc4 the last couple of days?
Created attachment 8962 [details] warnings about no types
Created attachment 8963 [details] my latest diff against rc4 for module sc on linux sparc
Hi Eike, I think this is something for you and/or Niklas. Frank
Set Platform/OS to Sun/Linux because of NOOPTFILES for Linux on Sparc, even if some of the patches are more All/All because of the type information thingy. Waiting for 1.1 branch to be created for porting.
making this depend on nWinkDiv issue 19054
Why making this depend on issue 19054? Any code including that svdtrans.hxx should show the warning.
Removing the depend on 19054. I did dmake clean and build OK with these patches (except nWinkDiv still to do but that is issue 19054)
See also issue 19098 (even if closed!), patch not copied because pasting from the description results in broken lines.
See also issue 19099 (even if closed!), patch not copied because pasting from the description results in broken lines.
See also issue 19102 (even if closed!), patch not copied because pasting from the description results in broken lines.
See also issue 19103 (even if closed!), patch not copied because pasting from the description results in broken lines.
See also issue 19104 (even if closed!), patch not copied because pasting from the description results in broken lines.
Sorry about that - I am new to this - is it useful for me to try and get rid of all these warnings or am i just being a pest? all those other patches are already in the attachment here at 18988. Where is IMPL_LINK defined? gcc-3.3 complains about these functions returning NULL, IMPL_LINK (param list) { return NULL; // should be return 0; }
Hi Sparcmoz (btw: what's your real name?) Please keep on reporting thos missing type stuff. As I already said, I'd like it more if compilers would bail out with an error on these, instead of saying nothing or just a warning in case of the lates gcc. IMPL_LINK is defined in tools/inc/link.hxx to return a long, so the compiler is right about 0 instead of NULL. So _all_ patches of the issues I just closed are contained in this sc_types.diff here? I didn't cross-check.
Q: So _all_ patches of the issues I just closed are contained in this sc_types.diff here? I didn't cross-check. A: yes i just copied them all out :) But be aware there some NOOPT things in there too, it was just my whole diff against rc4.
oh, my name is Jim Watson - i just cant figure how to make my name display - not trying to be mysterious at all...
now i understand what to do, i will make some more tidy patches with just the missing types things over the weekend.
Created attachment 9061 [details] return NULL warnings
Created attachment 9062 [details] patch for things with no types (and tokstack function had wrong type)
Created attachment 9063 [details] to return zero instead of NULL
Patches committed to branch cws_srx645_ooo111fix1. Note that I changed the sc/source/filter/xml/xmlsubti.hxx patch from const sal_Int32 nDefault... to const ScMysalIntVec::size_type nDefault...
While reviewing these changes I have noticed in sc/source/ui/view/makefile.mk I have added viewfun4.obj to the list of NOOPT files for other platforms (not linux sparc). This file should have been only for linux sparc, sorry.
Removed. I should have noticed.. Thanks for reviewing.
One more I overlooked :( the linux sparc patch to /sc/util/makefile.mk is no longer required, it was fixed in binutils debian bug 205548 see OOo issue 18250. 10/22/2003 06:36 er sc/ sc/ util/ makefile.mk 1.18.42.1.12.1 cws_srx645_ooo111fix1 6/4
Did undo that single change.
Integrated in m3s1.