Issue 17853 - Fixes to Desktop Entries for GNOME 2
Summary: Fixes to Desktop Entries for GNOME 2
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: thorsten.martens
QA Contact: issues@gsl
URL:
Keywords:
: 17351 (view as issue list)
Depends on:
Blocks:
 
Reported: 2003-08-04 15:19 UTC by mkretzschmar
Modified: 2004-01-30 13:26 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mkretzschmar 2003-08-04 15:19:33 UTC
Attaching some patches against the .desktop files for gnome in sysui

* in template.desktop use the fromtemplate script, not soffice slot:5500. For
consistency with KDE .desktop file

* s/Termnial=0/Terminal=false/ using 0 or 1 as boolean values is deprecated
(Desktop Entry Spec)

* add a TryExec line (Desktop Entry Spec)

---

* fix a typo in the Turkish translation

---

* add StartupNotify=true if WITH_LIBSN is YES, StartupNotify=false otherwise
(Startup Notification Spec)
Comment 1 philipp.lohmann 2003-08-04 17:51:58 UTC
pl->obr: please have a look
Comment 2 mkretzschmar 2003-08-04 18:23:43 UTC
You're looking for the patches? I'm still fighting Issuezilla.
Comment 4 nospam4obr 2003-08-05 07:28:12 UTC
Martin, Kevin, is there a time frame left to fix the turkish text
document string for 1.1 ?

I won't change template.desktop, because as soon as we switch to rpm
et al., we will start placing launchers to /usr/bin and I don't want
to place a "fromtemplate" there.

TryExec didn't work with full path in the past. The result (in KDE 2)
was, that the items did not show up at all. Did you actually see it
working with full paths in all Gnome 2 versions ?

Finally, does WITH_LIBSN get set by configure or where ? 
Comment 5 mkretzschmar 2003-08-05 11:01:31 UTC
template.desktop: you might consider changing the KDE file then. It
uses fromtemplate.

Full path in TryExec works with libgnome-desktop 2.3.3.1 here (out of
date development version) and libgnome-desktop 2.2.2 (stable version).

WITH_LIBSN was introduced in revision 1.54.2.6 of configure.in

http://ooo.ximian.com/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/var/cvsup&subdir=tools/config_office&command=DIFF_FRAMESET&root=/var/cvsup&file=configure.in&rev1=1.54.2.5&rev2=1.54.2.6

http://www.openoffice.org/issues/show_bug.cgi?id=16890
Comment 6 nospam4obr 2003-08-05 14:55:48 UTC
I am on vacation for the next 2 days, so if anyone thinks these issues
to be important enough to be in 1.1, someone else (maybe Michael)
should pick this one up. Otherwise I will target it for OOo 2.0.

In any case, since SO does not use this tree path, whatever is changed
here will not break StarOffice and thus does not need to my approvement. 
Comment 7 nospam4obr 2003-08-08 07:03:44 UTC
Accepting for OOo 2.0
Comment 8 nospam4obr 2003-08-18 10:09:31 UTC
Accepted.
Comment 9 nospam4obr 2003-09-25 08:16:32 UTC
I didn't add the TryExec line because I think this may cause trouble
on Gnome 2.0 and I haven't got the time to check right now. I also
don't think the value is high enough for this to go in 1.1.1.

I also haven't changed the slot:5500 for nearly the same reason.


What I did (and found important to do this for 1.1.1) is to 

* fix the turkish translation bug

* replace Termnial=0 with Terminal=false

* add StartupNotify=true if WITH_LIBSN is YES, StartupNotify=false
otherwise
Comment 10 mmeeks 2003-09-25 09:42:34 UTC
*** Issue 17351 has been marked as a duplicate of this issue. ***
Comment 11 nospam4obr 2003-09-29 07:09:21 UTC
Thorsten, please verify that 

a) in $HOME/.gnome2/vfolders/applications/ooo645writer.desktop the
turkish translation now contains "OpenOffice.org 1.1.0" instead of
PRODUCTNAME

b) All ooo645*.desktop files contain "Terminal=false" instead of
"Terminal=0"

c) All ooo645*.desktop files now contain "StartupNotify=false"
Comment 12 nospam4obr 2003-09-29 07:10:20 UTC
Restoring RESOLVED state - sorry for the spam.
Comment 13 thorsten.martens 2003-09-29 11:39:19 UTC
ATR: verified in cws sysui01, bug is fixed.
Comment 14 Olaf Felka 2004-01-30 13:26:27 UTC
of: Ok in srx645m27s1