Issue 17609 - IRIX: math stuff is in std namespace.
Summary: IRIX: math stuff is in std namespace.
Status: CLOSED WONT_FIX
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: SGI IRIX
: P3 Trivial (vote)
Target Milestone: AOO PleaseHelp
Assignee: sander_traveling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 809
  Show dependency tree
 
Reported: 2003-07-30 07:26 UTC by nickb
Modified: 2010-03-29 20:48 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2003-07-30 07:26:20 UTC 
tools/source/generic/line.cxx (sqrt)
tools/source/generic/poly2.cxx (cos sin)

Fix is a simple add std::sqrt std::cos and std::sin
Comment 1 Martin Hollmichel 2003-08-07 15:56:59 UTC 
set target milestone to 1.1.1
Comment 2 sander_traveling 2003-10-16 20:27:47 UTC 
commited in the ooo111fix1 branch
Comment 3 pavel 2003-10-17 22:46:51 UTC 
On Windows with this patch:

Making: ../../wntmsci9.pro/obj/line.obj
guw.pl /cygdrive/c/Progra~1/Micros~3/VC98/Bin/cl.exe -Zm200 -c -nologo
-Gs -Gy  
-I.  -I. -I../inc -I../../inc -I../../WIN/inc -I../../wntmsci9.pro/inc
-I. -I/cy
gdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/solver/645/wntmsci9.pro/inc/stl
-I/cyg
drive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/solver/645/wntmsci9.pro/inc/external
-I
/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/solver/645/wntmsci9.pro/inc
-I/cygd
rive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/solenv/wntmsci9/inc
-I/cygdrive/c/OOo/pa
vel/BuildDir/ooo_1.1.0_src/solenv/inc
-I/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0
_src/res
-I/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.0_src/solver/645/wntmsci9.pro/
inc/stl -I/cygdrive/C/jdk1.4.1_05/include/win32
-I/cygdrive/C/jdk1.4.1_05/includ
e -I'/cygdrive/C/Program Files/Microsoft SDK/include'
-I/cygdrive/c/Progra~1/Mic
ros~3/VC98/include     -I. -I../../res -I. -Ob1 -Ox -Oy- -Gd     
-DWNT -DWNT -D
NT351 -DMSC -DMI200 -DINTEL -D_USE_NAMESPACE -D_X86_=1  -DFULL_DESK
-DSTLPORT_VE
RSION=400 -DWINVER=0x400 -D_WIN32_IE=0x400 -D_MT -DCPPU_ENV=msci
-DSUPD=645 -DBU
ILD=8693 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0
-DOPTIMIZE -DEXCE
PTIONS_OFF -DCUI -DSOLAR_JAVA -DSRX645  -DHAVE_GPC_H -DMULTITHREAD
-DWIN32 -D_MT
 -D_DLL -DWIN32 -D_MT -D_DLL -W3 -Fo../../wntmsci9.pro/obj/line.obj
/cygdrive/c/
OOo/pavel/BuildDir/ooo_1.1.0_src/tools/source/generic/line.cxx

guw.pl /cygdrive/c/Progra~1/Micros~3/VC98/Bin/cl.exe @/tmp/mkb01512
Command: /cygdrive/c/Progra~1/Micros~3/VC98/Bin/cl.exe
line.cxx
c:\OOo\pavel\BuildDir\ooo_1.1.0_src\tools\source\generic\line.cxx(278)
: error C
2039: 'sqrt' : is not a member of '_STL'
dmake:  Error code 2, while making '../../wntmsci9.pro/obj/line.obj'
echo: No match.

ERROR: Error 65280 occurred while making
/cygdrive/c/OOo/pavel/BuildDir/ooo_1.1.
0_src/tools/source/generic
Comment 4 pavel 2003-10-17 22:47:16 UTC 
Sander?
Comment 5 sander_traveling 2003-10-17 23:17:07 UTC 
umm... worksforme? ok, I haven't tried windows and I seriously was not
expecting windows to be different from everything else in *this* way. 

I'll try to think of something
Comment 6 sander_traveling 2003-10-17 23:22:37 UTC 
I mean - math *is* in the std:: namespace
Comment 7 pavel 2003-10-18 15:19:47 UTC 
The same applies for the other file:

c:\OOo\pavel\BuildDir\ooo_1.1.0_src\tools\source\generic\poly2.cxx(862)
: error C2039: 'sin' : is not a member of '_STL'
c:\OOo\pavel\BuildDir\ooo_1.1.0_src\tools\source\generic\poly2.cxx(862)
: error C2039: 'cos' : is not a member of '_STL'

However, gcc on GNU/Linux and FreeBSD and also ForteC++ on Solaris can
compile this code.
Comment 8 quetschke 2003-10-18 21:24:56 UTC 
vq->svesik: MSVC build also breaks, see tinderbox.

(FreeBSD seems to work)
Comment 9 quetschke 2003-10-18 21:26:23 UTC 
Oops, Pavel was already talking about windows, sorry.
Comment 10 sander_traveling 2003-10-18 21:41:57 UTC 
yep. I'll try to figure out the why part today or tommorow, sorry
about the breakage, I really didn't anticpate it 8-(
Comment 11 quetschke 2003-10-23 15:20:56 UTC 
Can we please revert the patch until we have a solution that doesn't
break the windows build?
Comment 12 sander_traveling 2003-10-23 15:28:35 UTC 
yes, please revert
Comment 13 quetschke 2003-10-23 16:00:14 UTC 
Ok, reverted and committed in cws_srx645_ooo111fix1
Comment 14 sander_traveling 2003-12-10 15:41:34 UTC 
retarget to 1.1.2
Comment 15 caolanm 2010-03-29 20:48:21 UTC 
per issue 106845 sb removed the partial irix port, so this doesn't make sense in
isolation anymore106845
Comment 16 caolanm 2010-03-29 20:48:50 UTC 
closing