Issue 17603 - IRIX: MipsPro doesn't allow const_interator == iterator
Summary: IRIX: MipsPro doesn't allow const_interator == iterator
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: SGI IRIX
: P3 Trivial (vote)
Target Milestone: OOo 1.1.1
Assignee: jens-heiner.rechtien
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 809
  Show dependency tree
 
Reported: 2003-07-30 04:46 UTC by nickb
Modified: 2003-12-19 11:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2003-07-30 04:46:53 UTC 
cc-1323 CC: ERROR File =
/build1/nickb/openoffice/workarea/11rc/oo_1.1rc_src/bridges/source/jni_uno/jni_info.cxx,
Line = 466
  No operator "==" matches these operands.

            The operand types are:  std::hash_map<rtl::OUString,
                      jni_uno::JNI_type_info_holder, rtl::OUStringHash,
                      std::equal_to<rtl::OUString>,
                      std::allocator<jni_uno::JNI_type_info_holder>>::iterator
                      == std::hash_map<rtl::OUString,
                      jni_uno::JNI_type_info_holder, rtl::OUStringHash,
                      std::equal_to<rtl::OUString>,
                      std::allocator<jni_uno::JNI_type_info_holder>>::const_ite
                      rator.
      if (m_type_map.end() == iFind)


Changing it to iFind to an iterator (rather than const_interator) fixes this.
Comment 1 nickb 2003-07-30 04:47:33 UTC 
Here is the diff:
Index: jni_info.cxx
===================================================================
RCS file: /cvs/udk/bridges/source/jni_uno/jni_info.cxx,v
retrieving revision 1.8
diff -u -r1.8 jni_info.cxx
--- jni_info.cxx        23 Apr 2003 16:37:12 -0000      1.8
+++ jni_info.cxx        30 Jul 2003 03:50:39 -0000
@@ -435,7 +435,7 @@
         *reinterpret_cast< OUString const * >( &td->pTypeName );
     JNI_type_info const * info;
     ClearableMutexGuard guard( m_mutex );
-    t_str2type::const_iterator iFind( m_type_map.find( uno_name ) );
+    t_str2type::iterator iFind( m_type_map.find( uno_name ) );
     if (m_type_map.end() == iFind)
     {
         guard.clear();
@@ -462,7 +462,7 @@
         *reinterpret_cast< OUString const * >( &type->pTypeName );
     JNI_type_info const * info;
     ClearableMutexGuard guard( m_mutex );
-    t_str2type::const_iterator iFind( m_type_map.find( uno_name ) );
+    t_str2type::iterator iFind( m_type_map.find( uno_name ) );
     if (m_type_map.end() == iFind)
     {
         guard.clear();
@@ -489,7 +489,7 @@

     JNI_type_info const * info;
     ClearableMutexGuard guard( m_mutex );
-    t_str2type::const_iterator iFind( m_type_map.find( uno_name ) );
+    t_str2type::iterator iFind( m_type_map.find( uno_name ) );
     if (m_type_map.end() == iFind)
     {
         guard.clear();
Comment 2 nickb 2003-07-30 05:01:52 UTC 
More found in: 
comphelper/source/property/MasterPropertySetInfo.cxx
comphelper/source/property/ChainablePropertySetInfo.cxx
Comment 3 Martin Hollmichel 2003-08-07 15:56:57 UTC 
set target milestone to 1.1.1
Comment 4 sander_traveling 2003-10-16 21:38:29 UTC 
commited in ooo111fix1
Comment 5 Daniel Boelzle [:dbo] 2003-10-20 12:51:22 UTC 
I strongly disagree with these patches, which make the code worse. 
There are good reasons preferring a const_iterator over non-const
iterator.
Please choose another solution to workaround the IRIX MipsPro compiler
 problem, e.g. patch the stlport const_iterator typedef.
Comment 6 Daniel Boelzle [:dbo] 2003-10-20 12:52:07 UTC 
added to CC.
Comment 7 Daniel Boelzle [:dbo] 2003-10-20 12:52:54 UTC 
reopened.
Comment 8 Martin Hollmichel 2003-10-27 17:49:41 UTC 
revoked and set target to 1.1.2
Comment 9 jens-heiner.rechtien 2003-12-11 15:21:15 UTC 
.
Comment 10 Martin Hollmichel 2003-12-19 06:46:06 UTC 
mh->hr: was the last action to set target to 1.1.1 intentended, please provide
addtional information.
Comment 11 jens-heiner.rechtien 2003-12-19 11:29:31 UTC 
.
Comment 12 jens-heiner.rechtien 2003-12-19 11:30:06 UTC 
closing ...