Issue 17596 - IRIX: sal/osl/unx/system.h isn't right for MipsPro
Summary: IRIX: sal/osl/unx/system.h isn't right for MipsPro
Status: CLOSED WONT_FIX
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 RC
Hardware: SGI IRIX
: P3 Trivial (vote)
Target Milestone: AOO PleaseHelp
Assignee: sander_traveling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 809
  Show dependency tree
 
Reported: 2003-07-30 02:32 UTC by nickb
Modified: 2010-03-29 20:46 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to fix some compile issues with MIPSpro and icu (20.53 KB, text/plain)
2004-11-22 17:38 UTC, spaceacademy 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2003-07-30 02:32:39 UTC 
I haven't been able to find a way to get the program name programatically yet,
using MipsPro. 

So far, I've changed it to use AIX's ugly method of running ps -u %d -o args

Which works... but there must be a cleaner way... will keep looking.
Comment 1 nickb 2003-07-30 02:32:53 UTC 
Added dep
Comment 2 nickb 2003-07-30 03:55:57 UTC 
Ah, found it... its extern char **__Argv.

Will create a diff.
Comment 3 nickb 2003-07-30 04:39:58 UTC 
This compiles... haven't tested yet:
Index: system.h
===================================================================
RCS file: /cvs/porting/sal/osl/unx/system.h,v
retrieving revision 1.17.34.2
diff -u -r1.17.34.2 system.h
--- system.h    21 Jun 2003 14:38:05 -0000      1.17.34.2
+++ system.h    30 Jul 2003 03:43:13 -0000
@@ -351,7 +351,14 @@
 #   endif
 #      define  SA_FAMILY_DECL \
                union { struct { short sa_family2; } sa_generic; }
sa_union
+//#    define  CMD_ARG_PRG_IS_DEFINED
+#if !defined GCC
+#      define CMD_ARG_PRG      *__Argv
 #      define  CMD_ARG_ENV     _environ
+//#      define  CMD_ARG_PS                                    "ps -p
%u -o args=\"\""
+#else
+#      define  CMD_ARG_ENV     _environ
+#endif
 #      define  PTR_SIZE_T(s)                           ((int *)&(s))
 #      define  NO_PTHREAD_PRIORITY
 #      include <dlfcn.h>
Comment 4 nickb 2003-07-30 04:42:42 UTC 
Hmmm, This results in an undefined symbol, so its not 100% right yet.
Comment 5 Martin Hollmichel 2003-08-07 15:56:18 UTC 
set target milestone to 1.1.1
Comment 6 Martin Hollmichel 2003-10-17 08:21:12 UTC 
reassigned.
Comment 7 sander_traveling 2003-12-04 03:33:13 UTC 
retargeting to 1.1.2 - broken patch without update
Comment 8 spaceacademy 2004-11-22 17:38:33 UTC 
Created attachment 19584 [details]
Patch to fix some compile issues with MIPSpro and icu
Comment 9 spaceacademy 2004-11-22 17:53:03 UTC 
Added myself as CC above.
Comment 10 spaceacademy 2004-11-22 17:56:20 UTC 
I don't know why my patch got attached to this IZ??? It's supposed to go to 17595?
Comment 11 caolanm 2010-03-29 20:46:17 UTC 
per issue 106845 sb removed the partial irix port, so this doesn't make sense in
isolation anymore106845
Comment 12 caolanm 2010-03-29 20:46:32 UTC 
closing