Issue 12004 - W32-tcsh: Problem with macro $(APPxICON)
Summary: W32-tcsh: Problem with macro $(APPxICON)
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 644
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 12046
  Show dependency tree
 
Reported: 2003-03-03 17:42 UTC by quetschke
Modified: 2010-11-11 02:10 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for solenv/bin/guw.pl (936 bytes, patch)
2003-03-03 17:43 UTC, quetschke 		no flags Details | Diff
Patch for [_]tg_app.mk (1.36 KB, patch)
2003-03-03 17:44 UTC, quetschke 		no flags Details | Diff
Found entroll.btm, full _tg_app.mk and tg_app.mk (4.57 KB, patch)
2003-03-03 23:05 UTC, quetschke 		no flags Details | Diff
Patch for _?tg_app.mk (4.71 KB, patch)
2003-04-03 15:15 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2003-03-03 17:42:36 UTC 
In setup2/util the makefile fails to create a correct
  wntmsci7.pro/misc/setup.rc

1. Problem: In the following line in _tg_app.mk

 @-+guw.pl echo 1 ICON \"$(APP2ICON:s/\//\/\//)\" >> $(MISC)$/$(APP2LINKRES:b).rc
-----------------------^^
there are quotes around APPxICON, this is ok, but guw.pl cannot handle this.
The following guw.pl.diff teaches guw.pl the quotes. Now the path gets
translated to DOS notation, but only with single \.

This is not enough, for some reason rc needs \\ double backslashes,
see the 4nt part.

Btw. the $(APP2ICON:s/\//\/\//) part is wrong, the correct syntax would be:
$(APP2ICON:s!/!//!), but the double // are removed by guw.pl anyway.

The following tg_app.mk.diff fixes this for me. That is a patch for
tg_app.mk and for the APP2ICON part of _tg_app.mk

The entroll.btm is missing in the cws_... branches to generate the full
 _tg_xxx.mk files, and I don't want to change everything by hand.

ause: can you please generate a _tg_app.mk for cws_srx644_ooo_20030309 and
commit it.

Please approve

               Volker
Comment 1 quetschke 2003-03-03 17:43:21 UTC 
Created attachment 4965 [details]
Patch for solenv/bin/guw.pl
Comment 2 quetschke 2003-03-03 17:44:09 UTC 
Created attachment 4966 [details]
Patch for [_]tg_app.mk
Comment 3 quetschke 2003-03-03 17:45:07 UTC 
I take this issue
Comment 4 quetschke 2003-03-03 23:05:25 UTC 
Created attachment 4969 [details]
Found entroll.btm, full _tg_app.mk and tg_app.mk
Comment 5 quetschke 2003-03-04 10:19:36 UTC 
Approval pending added.
Comment 6 hjs 2003-03-10 13:05:21 UTC 
approved - looks fine to me...
Comment 7 quetschke 2003-03-11 09:07:26 UTC 
waiting for an open cws_srx644_ooo... ...
Comment 8 quetschke 2003-03-27 08:48:26 UTC 
Committed to: cws_srx644_ooo20030412
Comment 9 quetschke 2003-04-03 15:14:41 UTC 
The following is a fix for my own patch.

Replacing
  tr -s '\' '\\'
with
  sed 'sX\\X\\\\Xg'
because tr cannot replace one char with multiple chars.
Comment 10 quetschke 2003-04-03 15:15:29 UTC 
Created attachment 5441 [details]
Patch for _?tg_app.mk
Comment 11 quetschke 2003-04-03 15:20:01 UTC 
Committed to cws_srx644_ooo20030412.
Comment 12 quetschke 2003-06-27 09:22:11 UTC 
works
Comment 13 quetschke 2003-06-27 09:22:39 UTC 
close
Comment 14 phochalbuse 2010-11-11 02:10:09 UTC 
Created attachment 74032