Issue 11927 - Can not turn off some "AutoFormat while typing"
Summary: Can not turn off some "AutoFormat while typing"
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 1.0.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: oooqa
: 21197 (view as issue list)
Depends on:
Blocks: 13423 14813
  Show dependency tree
 
Reported: 2003-02-28 22:25 UTC by lohmaier
Modified: 2013-08-07 14:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description lohmaier 2003-02-28 22:25:25 UTC
Autoformat is always active even when the menu-entry is unchecked.
Steps to reproduce (this is reproducible 100%)
1) Open a textdocument
2) Turn off autoformat while typing using Format|AutoFormat->While Typing
3) Enter some text to which a autoformat configuration exists: eg: 1/2 *bold*  
   _underscore_ and so on

Actual results:
 1/2 is converted into a single character (½) *bold* is converted into a bold
formatted word, _underscore_ is converted to a word with underlining applied.

Expected results:
1/2 should stay 1/2, *bold* and _underlined_,etc should remain the way the user
typed them...

This also happens with OOo643. I consider this basic functionality and therefore
use P2
Comment 1 simonbr 2003-03-04 07:25:42 UTC
Confirmed with the Dutch build of 1.0.2 on Windows.
Fortunately, it is still possible to disable all autoformat options 
one by one, through the menu Tools>Autocorrection/Autoformat, Options 
tab.
Comment 2 lohmaier 2003-04-19 12:30:09 UTC
since all other qa members seem to be on vacation ;-) , I confirm my
own issue.

This still occurs with 1.0.3.1 
Comment 3 h.ilter 2003-04-23 16:47:39 UTC
Reassigned to SBA
Comment 4 eric.savary 2003-05-04 02:38:46 UTC
works fine in 644m9
Comment 5 eric.savary 2003-05-04 02:39:11 UTC
closed
Comment 6 lohmaier 2003-07-12 13:43:46 UTC
reopen issue. Still occurs with OOo 1.1rc (english version) -> target
milestone now: OOo 1.1
Comment 7 stefan.baltzer 2003-07-15 17:23:04 UTC
SBA->Christian: Even if YOU found this yourself and see it it as a big
annoyance, this is not Prio2. (or did I miss the crash? ;-) Prio
changed to P3.
Reassigned to Oliver.
Comment 8 lohmaier 2003-07-15 17:37:45 UTC
I took:
#  Basic functionality is not working correctly
as criterion (see original description), but P3 is fine...
Comment 9 lohmaier 2003-07-15 17:39:08 UTC
(Priority gidelines were new at that time...)
Comment 10 stefan.baltzer 2003-07-16 17:42:05 UTC
SBA->OS: It is not broken entirely ;-)

These ones don't get switched off after unchecking
"Format-Autoformat-While typing":

 - Use replacement table
 - Correct Two INitiaI CApitals
 - Capitalize first letter of every sentence
 - Automatic *bold* and _underline_
 - URL Recognition
 - Replace 1st... with 1^st...
 - Replace 1/2 with ½
 - Replace dashes
 - Ignore double spaces

These behave like expected (they do get switched off):
 - Delete spaces and dashes at beginnig and end of paragraph
 - Delete spaces and dashes at end and start of line
 - Apply numbering
 - Apply border
 - Create table
 - Apply styles
Comment 11 Oliver Specht 2003-07-17 15:16:00 UTC
It is not broken at all. 
The problem is that since AutoFormat and AutoCorrect have been merged
into one dialog page they cannot be distinguished anymore. 
OS->CJ: Any (good) idea?


Comment 12 christian.jansen 2003-07-22 07:45:45 UTC
CJ->OS: Yes, switch them off when Autoformat/While Typing has been
disabled. :-) Like some kind of manual override. In my opinion we do
not need to have some dialog changes
Comment 13 Oliver Specht 2003-07-25 14:32:42 UTC
Necessary changes: 
sw/source/ui/docvw/edtwin.cxx: 
diff -r1.70 edtwin.cxx
1941c1941,1943
<                       if( !aKeyEvent.GetRepeat() && pACorr &&
---
>
>             if( !aKeyEvent.GetRepeat() && pACorr &&
>                     pACfg->IsAutoFmtByInput() &&
1952c1954,1955
<                       else if( !aKeyEvent.GetRepeat() && pACorr &&
---
>             else if( !aKeyEvent.GetRepeat() && pACorr &&
>                         pACfg->IsAutoFmtByInput() &&
1984c1987
<                       if( pACorr &&
---
>             if( pACorr && pACfg->IsAutoFmtByInput() &&
4210c4213
<                 if(pACorr &&
---
>                 if(pACorr && pACfg->IsAutoFmtByInput() &&

sw/source/ui/shells/textsh.cxx:
diff -r1.27 textsh.cxx
364,365c364,367
<               SvxAutoCorrect* pACorr =
OFF_APP()->GetAutoCorrConfig()->GetAuto
Correct();
<               if( pACorr && pACorr->IsAutoCorrFlag( CptlSttSntnc |
CptlSttWrd
|
---
>             OfaAutoCorrCfg* pACfg = OFF_APP()->GetAutoCorrConfig();
>             SvxAutoCorrect* pACorr = pACfg->GetAutoCorrect();
>             if( pACorr && pACfg->IsAutoFmtByInput() &&
>                     pACorr->IsAutoCorrFlag( CptlSttSntnc | CptlSttWrd |
Comment 14 Oliver Specht 2003-08-11 07:19:41 UTC
Fixed in cws os16
sw/source/ui/docvw/edtwin.cxx
sw/source/ui/shells/textsh.cxx
Comment 15 Oliver Specht 2003-08-22 08:39:17 UTC
OS->MRU: cws os16 can be found on so-cwsserv02, wntmsci8 and unxsols4.pro
Comment 16 michael.ruess 2003-09-02 12:03:42 UTC
Checked fix with internal CWS os16.
Comment 17 michael.ruess 2003-09-02 12:04:37 UTC
Verified. Fix will be included in OO 1.1.1.
Comment 18 lohmaier 2003-10-15 17:54:17 UTC
*** Issue 21197 has been marked as a duplicate of this issue. ***
Comment 19 stefan.baltzer 2004-01-28 16:46:12 UTC
SBA: OK in internal build  srx645_m27-1_01.8737 (OOo 1.1.1 candidate). Closed.