Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Move #define UNICODE to makefile.mk - followup | ||||||
---|---|---|---|---|---|---|---|
Product: | Build Tools | Reporter: | hjs <hans-joachim.lankenau> | ||||
Component: | code | Assignee: | AOO issues mailing list <issues> | ||||
Status: | CONFIRMED --- | QA Contact: | |||||
Severity: | Trivial | ||||||
Priority: | P3 | CC: | carsten.driesner, issues | ||||
Version: | current | ||||||
Target Milestone: | --- | ||||||
Hardware: | All | ||||||
OS: | Windows, all | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
hjs
2007-06-20 13:41:39 UTC
Created attachment 46095 [details]
occurances of UNICODE in sources
Accept . . Retargeted. As this is a potential breakage for any code, we should see if it is possible to *always* use UNICODE/_UNICODE defined so that this define can be moved to the global mk file and PCH works again for all these files. This will comprise removing the define from all makefile.mk where we have added it for issue 77339. We also should change the code to use explicit typing (e.g. char or wchar instead of _TCHAR). Unfortunately it won't suffice to just compile the code, it's possible that a mix of explicit and wrapped typing in some code can lead to crashes or other bugs if it formerly was compiled without /DUNICODE. Reset assigne to the default "issues@openoffice.apache.org". |