Issue 99828 - Formula compiler string handling optimization
Summary: Formula compiler string handling optimization
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: recent-trunk
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL: http://wiki.services.openoffice.org/w...
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-03-03 16:26 UTC by ooo
Modified: 2017-05-20 10:20 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
test case document (602.08 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-03-03 16:30 UTC, ooo 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ooo 2009-03-03 16:26:14 UTC 
When compiling formulas, unnecessary string operations are carried out. For
details see http://www.openoffice.org/issues/enter_bug.cgi?component=Spreadsheet
Comment 1 ooo 2009-03-03 16:27:28 UTC 
Wrong clipboard content.. correct URL:
http://wiki.services.openoffice.org/wiki/Calc/Performance/string_handling_in_formula_compiler
Comment 2 ooo 2009-03-03 16:30:37 UTC 
Created attachment 60645 [details]
test case document
Comment 3 ooo 2009-03-03 16:34:15 UTC 
In cws calcperf04:

revision 268772
sc/source/core/tool/compiler.cxx
Comment 4 ooo 2009-04-24 16:46:56 UTC 
Reassigning to QA for verification.
You'll probably not notice much difference with the test case document, that was
meant for profiling.
Verify this doesn't break formula compiling during load and in UI.
Comment 5 joerg.skottke 2009-05-19 12:54:19 UTC 
As already indicated there is no measureable performance gain or loss.
Comment 6 oc 2009-05-26 14:28:44 UTC 
verified in internal build cws_calcperf04