Issue 99077 - Unnecessary copy of temporary file when saving ODF document
Summary: Unnecessary copy of temporary file when saving ODF document
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m41
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: mikhail.voytenko
QA Contact: issues@framework
URL:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2009-02-10 15:19 UTC by niklas.nebel
Modified: 2017-05-20 11:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description niklas.nebel 2009-02-10 15:19:39 UTC 
When a Calc file is saved (to ods), each xml stream is saved to a temporary file
and later committed to the package.

But the temporary file is copied again by the OWriteStream implementation. That
isn't really necessary in this scenario and should be avoided for performance
reasons (content.xml in Calc files can be quite large).
Comment 1 mikhail.voytenko 2009-04-20 13:54:35 UTC 
Changing the summary.
Comment 2 mikhail.voytenko 2009-04-20 13:57:42 UTC 
Fixed in cws os128
Comment 3 mikhail.voytenko 2009-05-15 10:43:53 UTC 
The new temp file is created now on demand, only if the stream is edited after
commiting. In the mentioned scenario it was indeed unnecessary.

I see no way to test the issue by QA. Setting to verified by myself as
development issue.