Issue 98991 - Remove Aqua Pinstripe background in dialogs
Summary: Remove Aqua Pinstripe background in dialogs
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 3.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial with 1 vote (vote)
Target Milestone: ---
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2009-02-07 11:15 UTC by rhwood
Modified: 2017-05-20 10:35 UTC (History)
5 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch (791 bytes, patch)
2014-05-27 20:33 UTC, Thorsten Wagner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description rhwood 2009-02-07 11:15:53 UTC
Apple began removing the Aqua Pinstripe backgrounds from UI elements in Mac OS X 10.3 Panther and 
had effectively removed the Pinstripe entirely in Mac OS X 10.5 Leopard[1]. OpenOffice 3.0.1 retains the 
pinstripes in (almost) all dialogs. It should be replaced with the Aqua backgrounds found in Leopard.

[1] http://en.wikipedia.org/wiki/Aqua_(user_interface)#Evolution
Comment 1 rvojta 2009-02-07 19:25:20 UTC
Yes, that's truth. These stripes should be removed.
Comment 2 thorsten.martens 2009-08-19 13:28:41 UTC
reassigned
Comment 3 sierkb 2009-09-10 14:55:06 UTC
Please be geared to the look of the menus and windows of Leopard and Snow
Leopard and the default proposals (Textured window look instead of the
old-fashioned and *very* outdated Pinstripe window look) of their Interface
Builder for Cocoa applications.

See also:
Apple Human Interface Guidelines: Window Appearance
http://developer.apple.com/mac/library/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGWindows/XHIGWindows.html#//apple_ref/doc/uid/20000961-TPXREF10

Quotes:
"All window-frame areas have a gray gradient surface. In the window body,
content views (such as text or column views) display a white background by
default; the surrounding window-body background is a shade of light gray."

"Important: In Mac OS X v10.5 and later, there are no brushed metal windows.
Windows that were designed as brushed metal windows to run in earlier versions
of Mac OS X should adopt the Leopard look in Mac OS X v10.5. For the most part
this is automatic. You may need to adjust your layout so that no window-frame
material is visible on the sides of the window and you should ensure that the
controls you used in the toolbar are still appropriate. See “Window-Frame
Controls” for more information on appropriate controls and “Legacy Toolbar
Controls” for some transition advice."
Comment 4 sierkb 2010-07-31 23:47:27 UTC
I want to bring to your mind ans attention, that this bug still is unfixed!

The dialogs still have a pinstripe background, the window-frame areas still are
white instead of default gray.

Please tend to the

Apple Human Interface Guidelines: Window Appearance
http://developer.apple.com/mac/library/documentation/UserExperience/Conceptual/AppleHIGuidelines/XHIGWindows/XHIGWindows.html#//apple_ref/doc/uid/20000961-TPXREF10

!

I quote again and stress:

"All window-frame areas have a _gray_ gradient surface. In the window body,
content views (such as text or column views) display a white background by
default; the surrounding window-body background is a shade of _light gray_."


Not white or pinstripe as seen yet...


-> bug's owner (Reporter) or staff: please raise the priority of this bug to
increase its attention.
Comment 5 Thorsten Wagner 2014-05-27 20:33:36 UTC
Created attachment 83473 [details]
Patch
Comment 6 Thorsten Wagner 2014-05-27 20:36:58 UTC
Please find a patch attached. To display a grey background within dialog windows "kThemeBrushDialogBackroundActive" is used. It should be ok as long as deprecated Carbon code hasn't been removed completely.
Comment 7 sierkb 2014-05-27 21:06:30 UTC
See also these relating LibreOffice bugs:

LibreOffice Bug 42082 - [META] Make LibreOffice shine and glow on OS X 
https://bugs.freedesktop.org/show_bug.cgi?id=42082

LibreOffice Bug 69358 - [Mac] Use OS native toolbar backgrounds / Review toolbar structure 
https://bugs.freedesktop.org/show_bug.cgi?id=69358

LibreOffice 4.3 Release Notes: GUI
https://wiki.documentfoundation.org/ReleaseNotes/4.3#GUI
Comment 8 SVN Robot 2014-05-28 11:43:03 UTC
"hdu" committed SVN revision 1597981 into trunk:
#i98991# remove Aqua Pinstripe background in dialogs
Comment 9 hdu@apache.org 2014-05-28 11:44:53 UTC
Thanks for the patch! And for the links! It looks much nicer indeed.