Issue 97515 - Refactor sc and svx to prepare for Excel export encryption and sheet protection support
Summary: Refactor sc and svx to prepare for Excel export encryption and sheet protecti...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: DEV300m37
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 60305 71468 84766
  Show dependency tree
 
Reported: 2008-12-22 21:22 UTC by kyoshida
Modified: 2013-08-07 15:14 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kyoshida 2008-12-22 21:22:09 UTC 
We need to refactor sc and svx modules in order to prepare for the future
integration of Excel export encryption and sheet protection options support. 
This change should not affect or alter any existing functionalities.
Comment 1 kyoshida 2008-12-22 21:23:38 UTC 
adding dr in the CC & set dependencies.
Comment 2 kyoshida 2008-12-22 21:24:08 UTC 
I'm taking ownership.
Comment 3 kyoshida 2008-12-22 21:24:22 UTC 
started.
Comment 4 kyoshida 2008-12-22 22:15:22 UTC 
set target to 3.1
Comment 5 kyoshida 2008-12-23 05:07:20 UTC 
fixed in the scsheetprotection02 cws just now.

I've done the following stuff to revert to the current behavior:

* disabled "Save with password" option for Excel export.

* disabled the new sheet protection dialog when protecting a sheet, and switched
back to the current simple password dialog.

* when saving an encrypted excel document, resurrected the old password warning
dialog and cleared the document password (if any), so that the document would
get saved *un*-encrypted *without* password.

* when importing an Excel document with document structure protection and/or
sheet protection with password, deliberately forget the password(s).  So, when
such an Excel document is opened in Calc, you can easily unprotect the
respective protection even without being prompted for a password.

* when exporting to an Excel document with document structure protection and/or
sheet protection with password, deliberately forget the password(s).  When such
a document is subsequently opened in Excel, you can easily unprotect the
respective protection even without being prompted for a password.

Basically, this change should not change any existing behavior.
Comment 6 kyoshida 2008-12-23 05:22:14 UTC 
Just an implementation note.  Re-enabling the features implemented in the
scsheetprotection02 should be as easy as 

* setting ENABLE_SHEET_PROTECTION from 0 to 1 in sc/inc/tabprotection.hxx, and
* removing the #if 0 #endif from the CheckPasswordCapability function object in
sfx2/source/dialog/filedlghelper.cxx.
Comment 7 oc 2009-01-22 14:02:48 UTC 
verified in internal build cws_scsheetprotection02
Comment 8 oc 2009-02-04 15:32:22 UTC 
set target to 3.2 as we don't want to split this (code changes now, strings
later) and we'll only loose one or two weeks with the integration because
release engineering is branching the versions (3.1 to 3.2)
Comment 9 kyoshida 2009-04-14 14:37:05 UTC 
Actually, this issue has already been verified...  I'll re-assign to oc again
just in case we need to verify this again (since it's a much more recent milestone).

If not, just set this back to verified fixed.
Comment 10 wope 2010-02-10 20:36:05 UTC 
testet with OOO320m12 and Excel 2007 SP2