Apache OpenOffice (AOO) Bugzilla – Issue 97339
gtk text boxes aren't highlighted like in native gtk applications
Last modified: 2013-07-30 02:19:02 UTC
Some gtk themes highlight text/input boxes. Openoffice's gtk integration/look doesn't do that. I'll attach a screenshot of a native gtk application.
Created attachment 58876 [details] native gtk input box
Change type from "Defect" to "Enhancement". Being a "good citizen" on all platforms is a valuable goal, but being slightly behind is not automatically a defect. http://qa.openoffice.org/scdocs/ddIssues_EnterModify.html#issuetype Put CMC, PL and myself on C/C. SBA->CMC: Is this one already on someones "good GTK citizen" list? SBA->CMC/PL: Is a solution WITHOUT UI change possible? ...that wohld make a feature and (all its pain :-) of this.
Add CCs.
Could you please state which specific gtk theme that is ? And on what Gnome and what linux it is available ? And what does OOo's gtk plugin look like in that theme ?
Created attachment 61800 [details] gtk themes
I attached a image. this is under gnome 2.26 and murrine gtk engine. Same exact thing happens under gnome's default gtk clearlooks theme.
Can confirm this anyway, and it would be a gsl thing to allow it to be drawn
Created attachment 61943 [details] maybe this is the roughtly the right thing to do
not sure if this is the right solution, but it does seem to give me correct-looking focus rectangles
that looks promising (that is similar to what the mac does, from which the blue focus rings are "inspired" anyway). But setting mbNoFocusRects to true means that in the gtk case focus rects will not be drawn anywhere; that is probably not the right thing to do in most themes.
I'm not too sure how its supposed to work at the moment, but AFAICS the gtkeditbox painter NWPaintOneEditBox never gets a "focused" state at the moment, so its not possible for it to ever paint itself as focused as that bit ironically is not set unless. else if( mbNWFBorder ) { if( pCtrl->HasFocus() || pCtrl->HasChildPathFocus() ) nState |= CTRL_STATE_FOCUSED; } inside brdwin.cxx
That bit is added for the mac (which is currently the only platform with mbNWFBorder). This also controls other related things like asking NWF for the width of said border (e.g. on the mac the blue ring is on the outside, so there needs to be space for it). Currently the mac is the only platform with native focus marking (the blue rings), all other focusing is done via the normal vcl method, which paints a dotted line around the focused control (e.g. checkboxes radiobuttons, listbox entries) or at least some text contained (e.g. push buttons).
the patch works really nicely :)
Reset assignee on issues not touched by assignee in more than 2000 days.