Issue 96624 - sot: remove new warnings
Summary: sot: remove new warnings
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: DEV300m36
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: mikhail.voytenko
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2008-11-26 15:21 UTC by caolanm
Modified: 2008-12-23 12:32 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to make warnings go away (1.46 KB, patch)
2008-11-26 15:22 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-11-26 15:21:19 UTC 
I get a few new warnings with a new gcc. Attached is a patch to remove them.
Just makes explicit what the compiler does implicitly. Current logic look fine.
Comment 1 caolanm 2008-11-26 15:22:11 UTC 
Created attachment 58328 [details]
patch to make warnings go away
Comment 2 caolanm 2008-11-26 15:23:14 UTC 
done in cmcfixes51
Comment 3 caolanm 2008-11-26 15:24:59 UTC 
cmc->mav: Happy to verify that this change isn't really a change, and that the
now explicit logic is what was intended ?
Comment 4 caolanm 2008-12-09 10:24:08 UTC 
verifying, current logic remains the same
Comment 5 mikhail.voytenko 2008-12-09 10:40:23 UTC 
I am awfully sorry that I did not answer, I had decided to answer next day and
have forgot it then. Indeed the logic is the same.
Comment 6 caolanm 2008-12-23 12:32:36 UTC 
seen DEV300_m38