Issue 96110 - sw: ambiguous & |
Summary: sw: ambiguous & |
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m35
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: andreas.martens
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2008-11-11 15:53 UTC by caolanm
Modified: 2013-08-07 14:43 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
suspicious code (536 bytes, patch)
2008-11-11 15:54 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-11-11 15:53:57 UTC 
& has precedence of |, so in 
sw/source/core/layout/frmtool.cxx
we have

 !((pLay->GetType()&FRM_FLY|FRM_SECTION)

which is effectively 

 !(((pLay->GetType()&FRM_FLY)|FRM_SECTION)

is that really want we intend ? or do we mean

 !((pLay->GetType()&(FRM_FLY|FRM_SECTION))

Guessing that it is the latter, then the following patch would make it the
second option. Otherwise an extra bracket or two I guess.
Comment 1 caolanm 2008-11-11 15:54:47 UTC 
Created attachment 57895 [details]
suspicious code
Comment 2 andreas.martens 2009-01-16 08:04:09 UTC 
Yeah, very suspicious :-(

Fixed in sw31bf02.
Comment 3 andreas.martens 2009-01-23 13:25:52 UTC 
Verified in CWS sw31bf02
Comment 4 caolanm 2009-03-23 16:20:29 UTC 
seen in m44, closing