Issue 96105 - svx: ambiguous & and |
Summary: svx: ambiguous & and |
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: DEV300m35
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: ooo
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2008-11-11 15:11 UTC by caolanm
Modified: 2010-01-23 12:49 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
what I suspect (478 bytes, text/plain)
2008-11-11 15:11 UTC, caolanm 		no flags Details
what I suspect we want to say (478 bytes, patch)
2008-11-11 15:11 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-11-11 15:11:14 UTC 
& has precedence over |

so in

svx/source/dialog/paragrph.cxx
we have
if(!(nHtmlMode & HTMLMODE_FULL_STYLES|HTMLMODE_FIRSTLINE) )
so we're saying
if(!((nHtmlMode & HTMLMODE_FULL_STYLES)|HTMLMODE_FIRSTLINE) )
but the spacing given to the & and the | makes me suspect we meant
if(!(nHtmlMode & (HTMLMODE_FULL_STYLES|HTMLMODE_FIRSTLINE)) )
is so, then patch attached to do that
Comment 1 caolanm 2008-11-11 15:11:42 UTC 
Created attachment 57892 [details]
what I suspect
Comment 2 caolanm 2008-11-11 15:11:51 UTC 
Created attachment 57893 [details]
what I suspect we want to say
Comment 3 ooo 2008-11-17 10:47:27 UTC 
verifying patch
Comment 4 ooo 2009-03-18 12:32:02 UTC 
retargeted to 3.2
Comment 5 ooo 2009-05-15 18:43:51 UTC 
fixed
Comment 6 ooo 2009-09-14 11:18:05 UTC 
verified
Comment 7 caolanm 2010-01-23 12:49:19 UTC 
closing