Apache OpenOffice (AOO) Bugzilla – Issue 96103
svx: dodgy code in svx
Last modified: 2010-01-23 12:49:44 UTC
in svx/source/dialog/svxruler.cxx we have... if(RULER_TYPE_BORDER == eType || RULER_TYPE_TAB == eType || RULER_TYPE_MARGIN1 && pColumnItem) which is odd, I suspect that we might want RULER_TYPE_MARGIN1 == eType at the least. After that its not totally clear if we mean if( RULER_TYPE_BORDER == eType || RULER_TYPE_TAB == eType || (RULER_TYPE_MARGIN1 == eType && pColumnItem) ) or if( (RULER_TYPE_BORDER == eType || RULER_TYPE_TAB == eType || RULER_TYPE_MARGIN1) && pColumnItem) Assuming the first one, then the patch attached would do that, but it would depend on the original intent of the code which I can't guess
Created attachment 57891 [details] suspicious code
verifying patch
retargeted to 3.2
I adjusted your patch a little bit to also take care of RULER_TYPE_BORDER and pColumnItem set, as is needed in the called method for both types: if( RULER_TYPE_TAB == eType || ( ( RULER_TYPE_BORDER == eType || RULER_TYPE_MARGIN1 == eType ) && pColumnItem ) )
verified
closing