Issue 93797 - Video does not play back in-place
Summary: Video does not play back in-place
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: OOO300m5
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: regression, release_blocker
Depends on:
Blocks: 88888
  Show dependency tree
 
Reported: 2008-09-11 22:15 UTC by hennerdrewes
Modified: 2008-10-02 10:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hennerdrewes 2008-09-11 22:15:19 UTC 
When playing back a video in a presentation, the video is played back in a
separate floating window with the caption "ActiveMovie Window". 

Tested with several video formats. All videos were inserted via "Insert Movie
and Sound". Results are the same with new presentations and presentations
created in prior versions.

In dev300_m19 it correctly played back in-place.

Vista Sp1.
Comment 1 hennerdrewes 2008-09-17 09:45:21 UTC 
I could reproduce this also on WinXP and Windows 2000. 

Video playback in slideshows is affected on all windows platforms (at least).
Comment 2 hennerdrewes 2008-09-17 09:47:15 UTC 
Added keywords
Comment 3 clippka 2008-09-17 13:54:52 UTC 
confirmed on windows on OOO300m5

forewarding to our avmedia specialist, but I also assume this may be caused by
some code changes from thb maybe?
Comment 4 hennerdrewes 2008-09-17 14:25:27 UTC 
Bug already present in DEV300_m25.
Comment 5 thb 2008-09-17 15:20:18 UTC 
eh. sorry, I'm not aware of any change that could have caused that - FWIW, works
just fine on Linux...
Comment 6 wolframgarten 2008-09-18 10:35:41 UTC 
Reproducible on WinXP with OOO300_m6 here.
Comment 7 wolframgarten 2008-09-18 10:40:16 UTC 
Ok in BEB300-m3.
Comment 8 wolframgarten 2008-09-18 10:41:27 UTC 
@ka: is this a possible showstopper?
Comment 9 clippka 2008-09-18 14:45:15 UTC 
cl->thb: consider changes to the implementation names of the different canvas
implementations, they have much more fancy names now. But that gives a clue why
in ViewMediaShape::implInitialize() the method
implInitializeDXBasedPlayerWindow() is never called.

but still, even that fixed gives a bogus window handler ... checking
Comment 10 fkbreitl 2008-09-18 14:51:37 UTC 
Problem also reported with issue 92475.
Comment 11 wolframgarten 2008-09-18 15:08:08 UTC 
Yes, but i92475 also covers the loop problem that i93797 does not mention. Thats
why i think they both are justified.
Comment 12 clippka 2008-09-18 15:11:41 UTC 
the call to avmedia's Player::createPlayerWindow() fails because the given HWND
is reported invalid from windows ::CreateWindow call. I try to find out where it
comes from...
Comment 13 thb 2008-09-18 15:16:25 UTC 
@cl: ah, right. I thought that this is fragile back when it was added already. ;)
Comment 14 clippka 2008-09-18 15:26:08 UTC 
the HWND is not bogus, it is just no HWND but a HDC, nice...
Comment 15 clippka 2008-09-18 17:52:01 UTC 
I changed

avmedia/source/win/window.cxx r. 1.6.24.1

so that if creating of the window fails it checks if the window handle is
actually a device handle and try to re create the window.

I also changed 

slideshow/source/engine/shapes/viewmediashape.cxx r. 1.6.14.1

to check for the correct implementation names...

fixed in cws impress160 for OOo 3.0
Comment 16 thb 2008-09-18 21:38:23 UTC 
@cl: thx - and sorry, I obviously broke that with canvas05. Unfortunately, Win32
is not a platform I run frequently...
Comment 17 clippka 2008-09-18 22:45:12 UTC 
verified in cws, back to qa

please check directx canvas & vcl canvas
Comment 18 wolframgarten 2008-09-19 08:31:34 UTC 
Seems to be fixed. but the "please click here to end the presentation " slide at
the end is missing. The m6 master still shows it. I assume that there is a
repaint missing after ending the movie?
Comment 19 wolframgarten 2008-10-02 10:43:07 UTC 
Tested in master m8. Closed.