Issue 9195 - Long list of recorded changes makes character deletion very slow
Summary: Long list of recorded changes makes character deletion very slow
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@sw
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2002-11-12 22:15 UTC by Unknown
Modified: 2013-08-07 14:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Document that exhibits the issue (142.94 KB, application/octet-stream)
2002-11-13 08:49 UTC, Unknown
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2002-11-12 22:15:23 UTC
If I press delete or backspace in a document that has very long list of recorded
changes, it takes over one second per character to perform the deletion. If I
select the text with mouse and then delete it, the delay is still noticeable,
but not so dramatical.

The PC is P3 900 MHz with 256 MB RAM.

There are no problems while inserting new text.

As a test I deleted all the contents in the document, but it did not improve
performance. When I accepted all changes using (Edit / Changes / Accept or
reject changes) performance became normal.

There should be some limit in the number of recorded changes or a warning to the
user if the side effect can not be removed.
Comment 1 brant 2002-11-13 02:22:11 UTC
Reporter, could you upload a file that exhibits the issue that you are
seeing?
Comment 2 Unknown 2002-11-13 08:49:44 UTC
Created attachment 3580 [details]
Document that exhibits the issue
Comment 3 prgmgr 2002-12-01 00:26:03 UTC
Issue 8518 has noted this problem.

*** This issue has been marked as a duplicate of 8518 ***
Comment 4 openoffice 2003-01-27 12:44:03 UTC
dvo: The phenomenon is indeed known. Due to some (older) design
decisions, there can be significant performance problems with long
documents and change tracking. Unfortunately, these design issues are
rather fundamental, so changing them will require rewriting
siginificant portions. So while there's agreement among the team that
these things should be changed, there is no agreement on how exactly
things should be changed, and also nobody has been willing to spend
the time.

dvo->christianseres: There is a rather trivial work-around for the
change tracking/performance problem: If changes are made visible,
performance should be normal. One can then turn of visible change
marks when printing.

dvo: So there's two things to do:
1) Consider the idea of a warning. I'll ask FL on that.
2) Deal with the performance (later). Since there's another issue with
this, I suggest this issue be closed when the waarning idea is
accepted or rejected. The performance issue will be dealt with
elsewhere. (Sorry; I forgot the number.)

dvp->prgmgr: I think that technically, this is not a duplicate of
#i8518#, so I'll reopen this.
Comment 5 openoffice 2003-01-27 12:46:02 UTC
dvo: Please considere the suggestion of issuing a warning. 
There is already an internal bug report (#94791#) for this. You may
find the bugdoc given there to allow easier reproduction of the problem.
Comment 6 frank.loehmann 2003-01-31 16:11:25 UTC
Set milestone
Comment 7 frank.loehmann 2003-02-10 15:46:42 UTC
We should show the following message in a box with an "i" icon and a 
OK/Abort button if deleting takes more than 1 second. The view 
setting will not be changed if the user presses abort instead of OK. 
If the user has pressed abort, OO/SO will not ask the user again for 
runtime of current doc (status will not be save within the doc).
FL->EM: Please finalize the following text and forward to DVO/OS:

01:"Record changes

Record changes is active for the current document, but show changes 
is not. This could cause performance problems when deleting text in 
large documents. Show changes will be enabled for this document to 
increase performance.

OK Abort"

49:"Änderungen aufzeichnen

Änderungen aufzeichnen ist für das aktuelle Dokument aktiviert, aber 
die Änderungen werden nicht angezeigt. Dieses kann zu einem 
Performanzproblem führen, sobald Text in umfangreichen Dokumenten 
gelöscht wird. Das Anzeigen der Änderungen wird für dieses Dokument 
automatisch angeschaltet, um die Performanz zu erhöhen.

OK Abbrechen"
Comment 8 elizabeth.matthis 2003-02-13 14:40:09 UTC
working on it
Comment 9 elizabeth.matthis 2003-02-13 18:02:43 UTC
Elizabeth -> OS: Here is the message in Ger + Eng. Please use a "?" as
symbol for the message box rather than the "i" as Frank suggested.

ENGLISH:
TITLE
%PRODUCTNAME %PRODUCTVERSION

BODY
In the current document, changes are being recorded but not shown as
such. In large documents, delays can occur when text is deleted. Do
you want to show the changes to avoid delays?

BUTTONS
Yes No

GERMAN:
TITLE
%PRODUCTNAME %PRODUCTVERSION

BODY
Im aktuellen Dokument werden die Änderungen aufgezeichnet aber nicht
als Solche angezeigt. In umfangreichen Dokumenten, kann es beim
Löschen von Text zu Verzögerungen kommen. Wollen Sie die Änderungen
anzeigen, um Wartezeiten zu vermeiden?

BUTTONS
Ja Nein
Comment 10 Oliver Specht 2003-02-14 08:21:59 UTC
->dvo: How should it be detected when to show the Box?
Comment 11 openoffice 2003-02-28 11:28:43 UTC
dvo->fl, Elizabeth: This can happen when
1) deleting
2) replacing, or
3) moving
text. All of these technically involve some form of deletion (replace,
move = delete + insert), but from a user perspective those are
probably different operations. Please change the wording to be more
general to accomdate this.
Comment 12 frank.loehmann 2003-03-03 15:39:52 UTC
We should change the text as follows:

GERMAN:
TITLE
%PRODUCTNAME %PRODUCTVERSION

BODY
Im aktuellen Dokument werden Änderungen aufgezeichnet aber nicht
als Solche angezeigt. In umfangreichen Dokumenten, kann es dadurch zu
Verzögerungen beim Bearbeiten des Dokumentes kommen. Wollen Sie die
Änderungen anzeigen, um Wartezeiten zu vermeiden?

BUTTONS
Ja Nein
Comment 13 elizabeth.matthis 2003-03-03 16:22:08 UTC
Elizabeth->DVO: See German from FL. Hers's the new English text.
ENGLISH:
TITLE
%PRODUCTNAME %PRODUCTVERSION

BODY
In the current document, changes are being recorded but not shown as
such. In large documents, delays can occur when the document is
edited. Do you want to show the changes to avoid delays?

BUTTONS
Yes No
Comment 14 openoffice 2003-03-05 12:50:06 UTC
dvo->Ocke: Please have a look at this.

There's three occasions where this happens, 2 in docedt.cxx and one
docnum.cxx (sw/source/core/doc). The problem areas are marked by
comments "MUSS noch optimiert werden".

The idea is that, when this code is executed and there are more than x
redlines in the redline table, the user should be asked to disable
redlines. However, the user should be asked at most once per document
per session.

For a wild guess, lets take x=500;
Comment 15 ocke.janssen 2003-03-05 13:18:14 UTC
.
Comment 16 ocke.janssen 2003-03-07 11:14:26 UTC
Fixed in cws SW008
Comment 17 ocke.janssen 2003-03-07 12:44:43 UTC
OJ->FS: Please verify.
Comment 18 ocke.janssen 2003-03-18 08:47:36 UTC
Please check in sw008. Thx.
Comment 19 stefan.baltzer 2003-03-31 13:45:51 UTC
Verified in CWS SW-008.
Comment 20 stefan.baltzer 2003-03-31 14:47:15 UTC
Set to fixed.
Comment 21 stefan.baltzer 2003-03-31 14:47:38 UTC
SBA: Set to verified.
Comment 22 thorsten.ziehm 2003-05-20 10:26:09 UTC
All tasks are verified in OOo1.1 Beta2