Issue 87264 - resource Ids used in wizards
Summary: resource Ids used in wizards
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-19 19:20 UTC by philipp.lohmann
Modified: 2017-05-20 11:33 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description philipp.lohmann 2008-03-19 19:20:00 UTC
following up issue 87245:
the java wizards seem to use resource Ids from at least svtools by their direct
numerical id. This breaks as soon as someone changes the Id in svtools since he
does not know that the wizards depend on that Id but cannot include svtools.hrc

I think a better approach than to use the direct values would be to use a c++
program that can include svtools.hrc and then creates a java import file that
can be used by the wizards.
Comment 1 philipp.lohmann 2008-03-19 19:21:04 UTC
pl->bc: if you're not the owner of the wizards anymore, please send this on to
the new owner.
Comment 2 philipp.lohmann 2009-12-16 10:45:24 UTC
@mba: please dispatch appropriately
Comment 3 Mathias_Bauer 2010-05-17 14:46:48 UTC
Hey cool, someone already found the bug that broke my build some weeks ago. :-)

Silly me - I just forgot about that. 
Perhaps instead of polluting the build we should solve that at runtime by
providing a UNO service that provides resource IDs.
Comment 4 philipp.lohmann 2010-05-17 15:21:18 UTC
polluting the product instead ?
Comment 5 Mathias_Bauer 2010-05-17 15:47:44 UTC
Not really. The generated output would be included in the product also, as a
java library. I think that adding a small C++ file implementing the UNO service
won't add more to our build. It does not need to be a UNO service, but that
would be the most simple implementation. And it would be usable anywhere where
UNO can be used, not only in Java applications.
Comment 6 philipp.lohmann 2010-05-17 16:18:01 UTC
Usable ? This would be a service, that translates local resource IDs of a wizard
into numbers (aka global resource IDs) which would the be passed to the UNO
service that actually loads the resource (as it already does). I think that is
not really a good concept and in fact would not be reusable at all.
Comment 7 Mathias_Bauer 2010-05-17 17:16:37 UTC
No; here we have the case that the wizard reuses a string resource that is
already defined and used elsewhere.

This string is kind of a part of the "interface" of the svtools library. If
there was an "svtools" object, I would make that string a part of its interface.
As such an object doesn't exist, why not creating one?

If that string was only made for the wizard, there would't be a reason to put
that string into the svtools resource.
Comment 8 Marcus 2017-05-20 11:33:30 UTC
Reset assigne to the default "issues@openoffice.apache.org".