Issue 86795 - mingw: catch-up fix for basegfx build breakage
Summary: mingw: catch-up fix for basegfx build breakage
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows, all
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: vg
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-07 13:09 UTC by vg
Modified: 2009-12-27 12:03 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
tono's patch (4.23 KB, text/plain)
2008-03-07 13:09 UTC, vg
no flags Details
breaker in berkeleydb (10.42 KB, text/plain)
2008-03-13 17:11 UTC, vg
no flags Details
breaker in libxslt (127.93 KB, text/plain)
2008-03-13 17:11 UTC, vg
no flags Details
Patch for berkeleydb (273 bytes, patch)
2008-03-15 11:58 UTC, tono
no flags Details | Diff
Patch for libxslt (340 bytes, patch)
2008-03-15 11:59 UTC, tono
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description vg 2008-03-07 13:09:02 UTC
.
Comment 1 vg 2008-03-07 13:09:42 UTC
Created attachment 51967 [details]
tono's patch
Comment 2 vg 2008-03-07 13:13:06 UTC
fixed in the CWS mingwport12
Comment 3 tono 2008-03-09 14:11:01 UTC
@vg: I was too busy last week to raise the issue for the patch. Thank you very 
much for taking care of it.
Comment 4 vg 2008-03-13 17:11:06 UTC
Created attachment 52077 [details]
breaker in berkeleydb
Comment 5 vg 2008-03-13 17:11:36 UTC
Created attachment 52078 [details]
breaker in libxslt
Comment 6 vg 2008-03-13 17:13:19 UTC
There are 2 additional problems since DEV300 m2. Please see attachments
Comment 7 tono 2008-03-15 11:57:21 UTC
@vg: The breaks in berkeleydb and libxslt are caused by the removal of 
expporting of the dmake macro PWD from solenv/inc/startup/wnt/macros.mk.

I will attatch patches to add it in makefiles of berkeleydb and libxslt and 
remedies the breaks.
Comment 8 tono 2008-03-15 11:58:43 UTC
Created attachment 52111 [details]
Patch for berkeleydb
Comment 9 tono 2008-03-15 11:59:18 UTC
Created attachment 52112 [details]
Patch for libxslt
Comment 10 quetschke 2008-03-15 22:18:49 UTC
Wait, wait, why is PWD exported there? The need to export it was stemming from
a dmake bug (fixed in 4.8 or so.). If you just without comment re-introduce it,
it might just go away again, when ause or I find it and thing this is not needed
anymore. So where is the bug?
Comment 11 tono 2008-03-15 23:53:50 UTC
@vq: As a side effect, the exporing of PWD had been helping the mentioned two 
external module build to use mixed path instead of cygwin path for the working 
directory. Without this, we have to modify the patch for configure scripts and 
makefiles conditionally for mingw.

I think just exporting PWD in mingw conditional part of the module makefiles 
in the two modules is simpler.
Comment 12 quetschke 2008-03-17 04:20:03 UTC
I am not opposed to exporting PWD, but we need a comment there pointing to this
explanation. Yes, that is a lucky coincidence that the PWD macro gets converted
to the mixed mode form and exporting it forces the following shell to use this
form.

Sounds a little fragile to me, but if it works for you ..

You should put it between

.IF "$(GUI)$(COM)"=="WNTGCC"
..
.ENDIF

as this is clearly platform dependent.
Comment 13 Martin Hollmichel 2008-03-18 09:11:35 UTC
set target
Comment 14 vg 2008-03-18 11:40:09 UTC
fixed in the CWS mingwport12
Comment 15 tono 2009-12-27 12:03:09 UTC
Closing the issue as the cws has already been integrated.