Issue 85987 - Remove external header guards from cppumaker-generated files
Summary: Remove external header guards from cppumaker-generated files
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: jsc
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-10 21:13 UTC by thb
Modified: 2008-07-29 15:16 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2008-02-10 21:13:46 UTC 
See $subject. CWS incguards01 intends to remove most external headers guards,
and the cppumaker/uno-skeletonmaker tools might follow suit.
Comment 1 thb 2008-02-10 21:14:23 UTC 
Target etc.
Comment 2 thb 2008-04-01 11:01:35 UTC 
@jsc: FYI, the big-bang incguards removal now takes place in CWS changefileheader
Comment 3 thb 2008-04-01 22:17:22 UTC 
Done en passant in CWS changefileheader (codemaker/source/cppumaker/includes.cxx).
Comment 4 thb 2008-04-01 22:18:45 UTC 
Fixed for cppumaker - jsc, want to tackle uno-skeletonmaker quickly tomorrow?
I'd otherwise split this issue...
Comment 5 thb 2008-04-01 22:20:11 UTC 
Eek, missing the addressant - jsc, want to tackle uno-skeletonmaker quickly
tomorrow? I'd otherwise split this issue...
Comment 6 jsc 2008-04-02 10:34:04 UTC 
jsc -> thb: i have it already fixed on cws jsc21 with issue number i72964. It is
fixed at least for cppumaker and i will check it for uno-skeletonmaker as well.
I am not sure if i have fixed it there as well.
Comment 7 jsc 2008-04-02 10:37:26 UTC 
yes, the uno-skeletonmaker is fixed as well
Comment 8 thb 2008-04-02 14:50:17 UTC 
@jsc: any objections if I keep the changes in changefileheader? They are exactly
the same as you did in jsc21 (but confined to includes.cxx) - given that jsc21
does not seem to have a target date yet, and I'd like to reap the benefits for
c++ code now...
Comment 9 jsc 2008-04-02 15:24:29 UTC 
well the benefits are marginal and i don't see a real demand for it. You can do
whatever you want but it doesn't make sense to fix the same things in 2
different cws. I thought it was clear that i will do it because i had the
modules in my cws anyway and i had clearly communicated that i will do it.
Comment 10 rt 2008-04-04 09:34:06 UTC 
Who shall verify this issue?
Comment 11 thb 2008-04-04 10:06:26 UTC 
@jsc: please verify in CWS changefileheader
Comment 12 jsc 2008-04-04 12:48:49 UTC 
verified on cws changefileheader
Comment 13 jsc 2008-07-29 15:16:06 UTC 
closed, checked on master