Issue 8585 - Configury updates for x86-64
Summary: Configury updates for x86-64
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: sander_traveling
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 8584
  Show dependency tree
 
Reported: 2002-10-22 14:53 UTC by gbeauche
Modified: 2004-08-12 17:27 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Configury changes for x86-64 (7.57 KB, patch)
2002-10-22 14:54 UTC, gbeauche
no flags Details | Diff
Updated patch for 1.0.2 (3.79 KB, patch)
2003-01-29 11:24 UTC, gbeauche
no flags Details | Diff
Add x86_64 to set_soenv.in (3.26 KB, patch)
2003-11-13 07:11 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description gbeauche 2002-10-22 14:53:21 UTC
Hi, this patch against OOo 1.0.1 changes some bits for x86-64 support. A point
to take care of is that x86-64 is a "lib64" platform. That is, native libraries
reside in */lib64 and 32-bit libraries remain in */lib.

However, OOo libraries used for the build process obviously have to remain in
*/lib. e.g. -L$SOLARENV/$OUTPATH/lib. Another point to consider is where Sun
will actually place x86-64 libraries for the JDK when ported. We don't need a
native JDK for the port. At the very least, gcj is enough.

Note: I chose OUTPATH="unxlngx4"
Comment 1 gbeauche 2002-10-22 14:54:05 UTC
Created attachment 3278 [details]
Configury changes for x86-64
Comment 2 Unknown 2002-10-23 15:33:31 UTC
I can check this patch in on the stable branch. However, on the 
developer branch, we got rid of set_soenv.1 and moved to set_soenv.in. 
Probably that change will occur on the next stable release, too. 
So you may want to adapt your patch later. 

Comment 3 Unknown 2002-10-30 13:39:41 UTC
patches checked in on OOO_STABLE_1. However, in the first hunk of 
the configure.in patch I had to change $CC to $GCC due to other 
recent changes. It would be great if you could confirm. 


Comment 4 Martin Hollmichel 2003-01-27 19:07:52 UTC
mh->gbeauche: please confirm as requested by Armin.
Comment 5 gbeauche 2003-01-29 11:24:47 UTC
Created attachment 4480 [details]
Updated patch for 1.0.2
Comment 6 gbeauche 2003-01-29 11:26:36 UTC
Patch updated to suit set_soenv.in from OOO_STABLE_1 (actually 1.0.2
here). Also note that original file didn't handle unxlngppc4 which I
added in my local tree. i.e. you may encounter a conflict/hunk reject
due to that.
Comment 7 gbeauche 2003-01-29 11:28:58 UTC
Note that I also assume Sun Java will leave jar files in */lib and
there would also be an "x86_64" subdirectory under */lib et al. i.e.
not using lib64 conventions here.

However, I don't know the current state of Sun Java native support for
x86-64. I would be happy to hear back from that, being a member of
SDC/JDC too.
Comment 8 Martin Hollmichel 2003-06-03 14:30:22 UTC
retarget to post 1.1 release
Comment 9 Martin Hollmichel 2003-10-09 09:51:38 UTC
reset target milestone
Comment 10 pavel 2003-11-13 07:10:46 UTC
I updated this patch to current cws_srx645_ooo111fix1.
Comment 11 pavel 2003-11-13 07:11:53 UTC
Created attachment 11214 [details]
Add x86_64 to set_soenv.in
Comment 12 pavel 2003-11-22 17:07:39 UTC
Sander,

please take a look at it.
Comment 13 foskey 2003-11-22 23:18:07 UTC
AIX is only sometimes 64bit, commit and I will fix it later.

Has this been verified on netBSD?  If so approved.
Comment 14 pavel 2003-11-23 11:24:36 UTC
@ken: I can verify this only on FreeBSD, is it enough for you? Why do
you want NetBSD specifically?
Comment 15 foskey 2003-11-23 11:52:56 UTC
 	($platform eq "$Irix64") || ($platform eq "$FreeBSD") ||
 	($platform eq "AIX"))
 {
-   $SOLAREXTRALIB     = $L.$par_dir.$LIB;
+   $SOLAREXTRALIB     = $L.$par_dir.$LIB64;
 }


These lines effect aix (I can check this later) and netbsd.
Comment 16 pavel 2003-11-23 14:39:55 UTC
Yes, it affects NetBSD and FreeBSD the same way, but:

 $LIB                  = $ds."lib";
+$LIB64                = $ds."lib"; 
+$LIB64               .= "64"
+if ($platform eq "Linux" && $machine_type eq "x86_64");

ie. LIB64 is the same as LIB except on Linux running on x86_64.

But I will verify this on FreeBSD. I do not have access to NetBSD box.
Comment 17 mrauch-openoffice 2003-11-23 14:58:01 UTC
From code inspection:
The patch looks fine for NetBSD, therefore also approved in that respect.
Comment 18 pavel 2003-12-27 17:13:19 UTC
Ken, do you think we can integrate to 20031216?
Comment 19 pavel 2003-12-28 12:06:18 UTC
Fixed on cws_src680_ooo20031216.
Comment 20 jens-heiner.rechtien 2004-08-12 17:27:12 UTC
Closing ...