Apache OpenOffice (AOO) Bugzilla – Issue 85747
--enable-mediawiki
Last modified: 2009-07-20 15:57:22 UTC
Attached a patch adding --enable-mediawiki for configure so that you can enable it in builds just with a configure switch. I don't know whether Sun wants to build it per default but I assume not (at least not in the "standard" build) as there's no module depending on the new swext. If you want, you need to set ENABLE_MEDIAWIKI to YES and add SWEXT to the BUILD_TYPE in ssrc680.ini[1]. Default currently (also for ./configure builds) is off. mav: ok to commit to wikiext01? I'll send the patch for the option for using system-libs for the apache common things later (need to find out how to best do that with build.xml)
.
Created attachment 51269 [details] patch
If the patch is ok, it will be integrated by release engineers during integration of the cws into the master. MAV->RT: Could you please take a look.
mav: eh, what? why a unncessary masterfix when you can do in the cws? Given that the cws and many issues of it are "new" anyway...
It can also be integrated into the cws itself, that will be a decision of the release engineer who will review and integrate the patch.
Created attachment 51306 [details] patch with support for using system libs
just attached patch also adds support for using the system libs directly for building
I do not know why a RE should review the patch beforehand, but of course an integration into CWS is prefered to masterfix. If it belongs to this CWS (and the description here lets me think so) it belongs into it.
mav: WTF do you need to involve REs into this? *You* are the cws owner and have to deliver a complete cws. The REs are not supposed to do what would be your job (except in exceptions, which this certainly isn't)
committed to the cws myself
A task of type PATCH is submitted to be reviewed and integrated, this is the patch handling process that I know. In this case the patch must be reviewed by the responsible engineer ( release engineer in this case ). If a change is integrated without review and not as a patch the engineer who has commit access does it himself. As it was done in this case. MAV->RENE: Thank you for the fix.
MAV->RENE: Doing the resync to m245 I have got a conflict in "configure", caused by the changes for this issue. Could you please solve the conflict, I will attach the file.
Created attachment 51396 [details] The "configure" file with conflicts.
mav: configure is a generated file. (by autoconf). If you can't deal with running autoconf, do the resync to the end (without configure) and I'll run autoconf but I don't see what the problem here is at all...
mav: hmm, just wanted to resync config_office myself. Which conflicts? $ cwsresync -m m245 config_office cwsresync -- version: 1.33 Argument "0.70_04" isn't numeric in numeric ge (>=) at /home/rene/OpenOffice.org/SRC680/solenv/bin/modules/Eis.pm line 194. cwsresync: cwsresync: ========== Merging 'config_office' ========== cwsresync: cwsresync: Retrieving changes for 'config_office' ... .. cwsresync: Check out 3 file(s) from module 'config_office' ... ... ... processing 3 merge candidate(s) ... ... do 3 actual merge(s) ... ... M configure: merged, schedule commit. M configure.in: merged, schedule commit. M set_soenv.in: merged, schedule commit.
Sorry, did not quite understand your last comment, which problem do you mean? Anyway, as I understood the generation of the "configure" needs an environment I can not reach easily currently. So it would be great if you commit the new version of the file, the sources resync is ready.
Did not see your last comment while writing my comment. I have the same output. But after the first step the "configure" file has conflicts, I have attached the file. The second step of the cwsresync was affected by the conflict.
mav: I don't have any clue at all what's so hard to use the resynced configure.in for producing configure by just running autoconf in config_office. Really. Done anyway now...
I would need a machine with the autoconf of correct version for example. Not everybody builds using autoconfig. And if the generation of the file is so easy, why are we still discussing it? Thank you for cooperation.
After the task 87643 has been fixed the OOo build works well with "--enable-mediawiki" as I understood. So I set the task to verified.
This issue is closed automatically and wasn't rechecked in a current version of OOo. The fixed issue should be integrated in OOo since more than half a year. If you think this issue isn't fixed in a current version (OOo 3.1), please reopen it and change the field 'Target Milestone' accordingly. If you want to download a current version of OOo => http://download.openoffice.org/index.html If you want to know more about the handling of fixed/verified issues => http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues