Issue 85726 - binary-only jars in swext/mediawiki/jars
Summary: binary-only jars in swext/mediawiki/jars
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: current
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: rene
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-30 14:02 UTC by rene
Modified: 2013-08-07 14:43 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description rene 2008-01-30 14:02:02 UTC 
Hi,

prompted by issue 85633 I looked what swext is. Good that I did..

rene@frodo:~/sw/swext/mediawiki$ ls
build.xml  CVS  dialogs  jars  makefile.mk  src

Hmm. jars? I feel something bad...

rene@frodo:~/sw/swext/mediawiki$ cd jars
rene@frodo:~/sw/swext/mediawiki/jars$ ls
commons-codec-1.3.jar         commons-lang-2.3.jar     CVS
commons-httpclient-3.0.1.jar  commons-logging-1.1.jar  Tidy.jar

Bingo.

Those should *not* be shipped in binary-only form. commons-* seems to map with
"normal" packages (I didn't look into its contents, though, but I have bad
feelings given tidy.jar, see below..), but Tidy.jar is a complete mess...

The only trace of a Tidy.jar I find in Debian is jtdy.jar
(packages.debian.org/libjtidy-java in version 7+svn20070309-1), which does
contain only org/w3c/tidy whereas Tidy.jar in CVS contains a
org/w3c/org/w3c/dom, org/w3c/tidy and org/xml/sax subdirs.
Is those additional dirs needed? What is patched in there? Is it something else?

Should be fixed before integration of cws wikiext01.
Comment 1 rene 2008-01-30 14:49:49 UTC 
just tried it; replaced Tidy.jar with jtidy.jar (and the rest with the jars
Debian has, too) and it still built.
Comment 2 mikhail.voytenko 2008-01-30 16:50:11 UTC 
Tidy.jar should be removed anyway, it is not used any more.
Comment 3 rene 2008-01-30 20:23:49 UTC 
ok, Tidy.jar got removed, adapting summary
Comment 4 rene 2008-01-30 20:28:04 UTC 
.
Comment 5 rene 2008-02-01 12:42:17 UTC 
reassign
Comment 6 rene 2008-02-01 12:42:38 UTC 
working on it
Comment 7 rene 2008-02-04 09:02:29 UTC 
fixed. new modules: external/tomcat, external/apache-commons
Comment 8 mikhail.voytenko 2008-03-28 14:31:36 UTC 
Verified the fix in wikiext01 cws.
Comment 9 thorsten.ziehm 2009-07-20 15:56:03 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues