Issue 85610 - SRC680_m244:Unassigned shell variable $GREP used in config_office/configure.in
Summary: SRC680_m244:Unassigned shell variable $GREP used in config_office/configure.in
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.4
Assignee: rene
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-26 15:26 UTC by tono
Modified: 2009-08-30 00:48 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2008-01-26 15:26:32 UTC
Unassigned shell variable $GREP is used in config_office/configure.in.

As AC_PROG_EGREP depends on AC_PROG_GREP after autoconf 2.61 and 
AC_HEADER_STDC depends on AC_PROG_EGREP, $GREP may happen to be assigned in 
some cases.

However, in win32 build with MS tools AC_HEADER_STDC is never invoked and 
$GREP at line 2985 will always fail. Other use of $GREP is not invoked in 
win32 build but we should consistently avoid using $GREP or invoke 
AC_PROG_GREP explicitly.
Comment 1 fridrich.strba 2008-01-28 10:08:42 UTC
in a masterfix of SRC680_m244, we changed all occurences of $GREP to $EGREP.
This issue is then fixed. Please verify
Comment 2 vg 2008-01-28 12:14:02 UTC
reassign for verification
Comment 3 tono 2008-01-28 14:21:43 UTC
As Macro EGREP may not be assigned in win32 build, replacing $GREP with $EGREP 
does not work. Plain grep should be used (it is used everywhere) unless we 
explicitly specify AC_PROG_GREP or AC_PROG_EGREP.
Comment 4 rene 2008-01-28 18:43:16 UTC
tono: you're wrong, plain GREP is not used everywhere. And as you said, plain
$GREP also has problems.

We need a cws to unify this. (And add the explicit check)
Comment 5 pavel 2008-01-28 18:43:48 UTC
.
Comment 6 pavel 2008-01-28 19:06:42 UTC
The error message is:

checking for gperf... /usr/bin/gperf
checking gperf version... ./configure: line 11406: ^GNU gperf: command not found
./configure: line 11406: test: : integer expression expected
configure: error: too old, you need at least 3.0.0

Comment 7 tono 2008-01-28 22:05:44 UTC
@rene: I meant that not using macro variable but specify grep directly. 
Comment 8 maho.nakata 2008-01-29 04:35:24 UTC
pjanik:
please refer
http://www.openoffice.org/issues/show_bug.cgi?id=85590
as well.
IMHO we need this part.
Comment 9 rene 2008-01-29 12:54:55 UTC
maho: paveljanik didn't question that. in fact, he was the one who found we need
it :-)
Comment 10 rene 2008-01-29 15:39:35 UTC
fixed in cws grepcheck
Comment 11 fridrich.strba 2008-01-29 15:43:17 UTC
seen good in grepcheck, let's push for 2.4
Comment 12 tono 2009-08-30 00:48:29 UTC
Closing.