Issue 8387 - Please adapt fp exception macros for Linux to latest glibc interface
Summary: Please adapt fp exception macros for Linux to latest glibc interface
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta
Assignee: Unknown
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 11319
  Show dependency tree
 
Reported: 2002-10-16 08:08 UTC by Unknown
Modified: 2003-03-13 11:10 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
makes fp exception macros common for all Linux platforms (1.93 KB, patch)
2002-10-16 08:10 UTC, Unknown 		no flags Details | Diff
Alternative FP_EXCEPTIONS implementation for Linux for S/390. (674 bytes, patch)
2002-12-20 14:32 UTC, Unknown 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2002-10-16 08:08:58 UTC 
Hi,
the glibc provides now a common interface to the fp exceptions in fenv.h. Could
you adapt the code as proposed in the attached patch. This makes porting easier
to other Linux platforms.

Gerhard
Comment 1 Unknown 2002-10-16 08:10:00 UTC 
Created attachment 3188 [details]
makes fp exception macros common for all Linux platforms
Comment 2 Unknown 2002-11-05 10:41:32 UTC 
want opinion from porting project
Comment 3 Unknown 2002-12-20 14:32:00 UTC 
Created attachment 4128 [details]
Alternative FP_EXCEPTIONS implementation for Linux for S/390.
Comment 4 Unknown 2002-12-20 14:34:20 UTC 
In case you don't want to change the implementation for all Linux
platforms, I have attached an alternative implementation for Linux for
S/390 only.
Comment 5 khendricks 2002-12-21 13:43:10 UTC 
Hi,  
  
solmath.hxx.diff defintely *NOT* approved.  You have removed a  
workaround that is needed for building under gcc 3.1 on ppc Linux.  
 
Please do NOT submit patches removing any PPC Linux pieces without 
first asking me.  I have been trying to get all of the patches to 
support PPC Linux into the tree for almost 2 years now and pieces of 
them keep disappearing.  This disappearing act needs no help!  ;-) 
Also what is the minimum glibc version required to support your 
unifaction effort?  Unless these macros existed under glibc-2.1.3, 
we should probably not change them since some distributions on 
non-x86 still use that glibc version "officially". 
 
Your solmath-s390-2.diff *is* approved since it will impact no one 
else. 
 
 
Kevin
Comment 6 Unknown 2003-02-09 17:54:41 UTC 
Patch committed to branch cws_srx644_ooo20030223.
Comment 7 Martin Hollmichel 2003-02-10 09:21:04 UTC 
approved.
Comment 8 ooo 2003-02-10 11:17:29 UTC 
Just to add my 2 cts.:

Kevin is right, as long as we use "old" glibc versions we definitely
need the old hacked macros too.

NOTE that all tools/inc/solmath.hxx functionality was shifted down to
sal/inc/sal/mathconf.h and sal/inc/rtl/math.{h,hxx} on branch
cws_srx644_rtlmath, which is to be merged back to mws_srx644 soon, and
the S390-patch will have to be reapplied then.
Comment 9 Unknown 2003-02-13 06:05:42 UTC 
The patch has been committed, but not yet verified.
Comment 10 Martin Hollmichel 2003-02-17 17:06:42 UTC 
in cws_srx644_ooo20030223
Comment 11 michael.bemmer 2003-03-13 11:10:03 UTC 
As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for details.