Issue 8385 - Please remove code of obsolete S/390 architecture
Summary: Please remove code of obsolete S/390 architecture
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Other Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta
Assignee: sander_traveling
QA Contact: issues@porting
URL:
Keywords:
Depends on:
Blocks: 10150 10152 11319
  Show dependency tree
 
Reported: 2002-10-16 07:33 UTC by Unknown
Modified: 2003-03-13 11:10 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
removes obsolete S/390 architecture (32.62 KB, patch)
2002-10-16 07:34 UTC, Unknown 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Unknown 2002-10-16 07:33:02 UTC 
I am going to release a patch for Linux for S/390. The CPUNAME S390 is already
used by another, but obsolete architecture, as we were told in

http://porting.openoffice.org/servlets/ReadMsg?msgId=379409&listName=dev

Attached is a patch to remove the code fragments. If it is approved I will reuse
the CPUNAME and post my patch.

Thanks,
Gerhard
Comment 1 Unknown 2002-10-16 07:34:49 UTC 
Created attachment 3187 [details]
removes obsolete S/390 architecture
Comment 2 chris 2002-12-19 13:47:15 UTC 
Patch only removes obsolete S390 architecture and does not affect the
rest of the code.  It is already applied sucessfully to the Debian
packages of 1.0.1.

The only comment I would have is the style of

-#if defined(foo) || defined(S390)
+#if defined(foo)

instead of going to the more common

#ifdef foo

but that is a style issue and not really important.

Patch approved.
Comment 3 Unknown 2003-02-09 17:54:06 UTC 
Patch committed to branch cws_srx644_ooo20030223.
Comment 4 khendricks 2003-02-10 14:14:11 UTC 
Hi, 
 
Shouldn't we change this issue to FIXED now that the S390 patches 
are in? 
 
Kevin
Comment 5 foskey 2003-02-12 12:19:51 UTC 
Can we please close this issue?
Comment 6 sander_traveling 2003-02-12 13:11:00 UTC 
sure - if its fixed / commited to the branch that will bemerged it
should be closed.

closing
Comment 7 Martin Hollmichel 2003-02-17 17:05:57 UTC 
in cws_srx644_ooo20030223
Comment 8 michael.bemmer 2003-03-13 11:10:01 UTC 
As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for details.