Created attachment 3147 [details]
patch for latest nas and also bison fix.

Created attachment 3169 [details]
patch to make idlc compile under bison 1.5

I don't know about any decision whether we move to nas 1.5, 
so I'll keep this on hold and cc Martin Hollmichel

as long as all versions from 1.27 on are supported by these patches
I'm fine with these patches. if not we have to find a solution for it.

The nas patch (id 3147) is specific to nas 1.5, I guess, and my 
question was mainly targeted at that.

Created attachment 3173 [details]
Updated patch from 1.4.1

but now you have patches for both 1.4.1 and 1.5g in there? 

Created attachment 3512 [details]
bison 1.75 patch for sqlbison.y

I just added a patch to be able to build OOo with bison 1.75.

With all patches, 1.01 and also the 643 branch build fine with
bison 1.75.

Martin

In order to update nas to a good version:  Grab the latest version of
nas from: http://radscan.com/nas/nas-1.6.src.tar.gz  rename it without
the .src.  Move this to the nas/download directory.

Take the 1.5g patch and rename it as 1.6,  change all references in
the patch file from 1.5g to 1.6 and all will then build  (s/1\.5g/1.6/g)

I just applied and tested the NAS patch and it worked perfectly.

Updated wrong issue,  resetting approval keyword.

TEsted to make and install a basic configuration.  There were no major
errors once updates applied.

Approved.  Applies, builds and installs in my environment without
problems - both the bison build fix and version 1.6

Chris

Committed the NAS patches to upgrade to 1.6.

Note that we should 'un'tag the original version after a proving period.

mh-> jsc, fs, please take a look at patches for connectivty and idlc
and  approve.

Ocke, you know the sqlbison.y much better than me, yould you please
have a look at Ken's patch and approve it? Thanks.

Hi Martin,

I've got some questions about your patch. 
What happens to the missing tokens like SQL_TOKEN_BIT_LENGTH or
SQL_TOKEN_POSITION? 

Best regards,

Ocke

If you look closely  you will find that these are duplicate definitions.
bison 1.3X is forgiving about this, bison 1.75 is much more strict
hence the deletions.

I dont proclaim expertese with bison,  it works and it builds and
installs.

oj->mh: patch for sqlbison.y approved.

Applied connectivity patch to OO743C.  Only waiting approval for idlc
patch.

Waiting for the approval of idlc directory.

Hi Chris,   
   
Since I just updated the OOO_STABLE_1 tree with idlc from OO643C and  
if those changes were already in OO643C then the idlc.bison patch  
should already be in OOO_STABLE_1.  
 
But I am now confused as to which patches are yet needed to support 
bison 1.75 in OOO_STABLE_1 
 
Which of the attached patches listed in this issue should still be 
applied to OOO_STABLE_1? 
 
My guess is: 
 
nas-1.4.1.patch 
patch-connectivity+source+parse+sqlbison.y 
 
Is that correct? 
 
Thanks, 
 
Kevin 
 
  

The idlc patch has never been approved and therefore never applied to
OO643C, hence the approval pending tag!

The connectivity and nas patches are required to make OOO_STABLE_1
work using bison > 1.35.

Hi Ken, 
 
The updates nas-1.4.1.patch does not apply at all since 
server/dia/gram.y differs significantly between the 1.4.1  
version and the 1.5 version. 
 
Specifically 
 
  		| GAIN number 
! 			{ ddaSetConfig(GAIN, (void *)$2); } 
 
 
The term GAIN is not even found in gram.y at all under this version. 
 
Can someone please take a closer look at this patch for nas-1.4.1 
and put up a corrected version for use with OOO_STABLE_1. 
 
Thanks, 
 
Kevin 
 

Created attachment 4232 [details]
a newer patch for OOO_STABLE_1 for nas

Hi, 
 
Can someone with a newer bison please try the newer nas-1.4.1.patch 
(replace the one in nas) in the OOO_STABLE_1 tree and tell me if it 
fixes the issue? 
 
Also, I have some questions about the idlc patch (and I am no bison 
expert about all of the added {}. 
 
The other part of that patch is similar to the nas and connectivity 
patches in that they add back in missing semicolons but the idlc 
patch adds in braces too. 
 
We really need a bison prop to tell us what is up here. 
 
Kevin 
 

Hi,   
   
Okay I have applied the idlc parser.y patch and completely rebuilt   
idlc and delivered it then I used the new idlc to rebuild udkapi   
and compared before and after with absolutely no changes.   
  
So I now have a hopefully working nas-1.4.1.patch and a  
connectivity sqlbison.y patch and an idlc parser.y patch that seem  
to be working fine with older versions of bison and will hopefully  
work fine with newer versions in OOO_STABLE_1.  
  
So under the approval for updating OOO_STABLE_1 for the newer build  
tools (since bison is a newer build tool ;-), I am going to commit 
them to OOO_STABLE_1 now and if anyone objects tomorrow (or the nas 
patch needs more work) we can revert  
them easily.  
  
So hopefully all will now work even under newer bison.  
  
The commits are now in the tree. 
 
Here are the new version numbers and the previous ones in case we 
need to revert these since we are sort of stretching the "approval" 
a bit here. 
 
I have tested all of these with my old version of bison and they 
cause no trouble. 
 
nas/nas-1.4.1.patch version 1.1.6.1 replaces version 1.1 
 
connectivity/source/parse/sqlbison.y version 1.34.4.3 replaces 
version 1.34.4.2 
 
idlc/source/parser.y version 1.2.2.2 replaces 1.2.2.1 
 
Hope this helps,  
Kevin  
  
   

This issue has now been resolved.  Stable and 643C now build with new
bison.

Committed idlc/source/parser.y to branch cws_srx644_ooo20030223.

new revision: 1.1.14.1; previous revision: 1.1

As discussed with Armin, he thought these bug were closed, he sees all of them
as verified.

As discussed with Armin, he thought these bug were closed, he sees all of them
as verified.