Issue 81332 - DeleteArea unnecessarily broadcasts multiple changes to identical listeners already notified.
Summary: DeleteArea unnecessarily broadcasts multiple changes to identical listeners a...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: 680m226
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: frank
QA Contact: issues@sc
URL:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-09-06 15:31 UTC by ooo
Modified: 2013-08-07 15:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
test case needing 12s on my machine, see instructions inside (47.98 KB, application/vnd.oasis.opendocument.spreadsheet)
2007-09-06 15:34 UTC, ooo 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ooo 2007-09-06 15:31:05 UTC 
Deleting a larger cell range that is referenced by many formulas takes a long
time. This scenario is sometimes used in spreadsheet documents using VLOOKUP on
a range linked to an external document when the linked data is updated, the
range then is cleared first.
Comment 1 ooo 2007-09-06 15:34:19 UTC 
Created attachment 48018 [details]
test case needing 12s on my machine, see instructions inside
Comment 2 ooo 2007-09-06 15:35:49 UTC 
Started.
Comment 3 ooo 2007-09-06 15:54:02 UTC 
In cws calc44:

sc/inc/document.hxx  1.102.38.1
sc/source/core/data/bcaslot.cxx  1.8.70.1
sc/source/core/data/document.cxx  1.79.62.1
sc/source/core/data/table2.cxx  1.37.162.1
sc/source/core/inc/bcaslot.hxx  1.5.70.1

Time needed now ~0.5s, an improvement by at least factor 23. On larger ranges
and with more formulas involved it will be even more. In a customer's document 
time needed was brought down from 15 minutes to 7 seconds, which is a
performance gain by factor 127.
Comment 4 kyoshida 2007-09-06 17:52:36 UTC 
Funny I was just looking into the same issue. :-)
Comment 5 niklas.nebel 2007-09-18 14:03:37 UTC 
Reassigning to QA for verification.
Comment 6 frank 2007-09-26 14:27:23 UTC 
found fixed on cws calc44 using Linux, Solaris and Windows
Comment 7 frank 2007-12-14 12:47:08 UTC 
found integrated on master m239 using Linux, Solaris and Windows build