Issue 81185 - Adapt makefiles to new $(mktmp ..) behavior
Summary: Adapt makefiles to new $(mktmp ..) behavior
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.3.1
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 64234
  Show dependency tree
 
Reported: 2007-09-01 03:45 UTC by quetschke
Modified: 2009-02-24 11:51 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for solenv/inc (1.66 KB, patch)
2007-09-01 08:56 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2007-09-01 03:45:48 UTC 
After issue 64234 got fixed mktmp some problems arose.

This 

$(TYPE) $(mktmp $(foreach,i,$(all_local_obj:b:+".obj") $@ : $(OBJ)$/$(i:+"\n"))
$(foreach,i,$(all_misc_obj:b:+".obj") $@ : $(OBJ)$/$(i:+"\n"))) >> $@

in rules.mk creates something like this:

../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_cpp.obj
 ../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_eval.obj
 ../wntmsci10.pro/misc/all_cpp.dpobj : ../wntmsci10.pro/obj/_getopt.obj

and the leading space makes this a recipe line. This breaks the build, but can
be fixed by using
  $(@:^"\n") : $(OBJ)$/$i
instead.
Comment 1 quetschke 2007-09-01 08:56:32 UTC 
Created attachment 47907 [details]
Patch for solenv/inc
Comment 2 quetschke 2007-09-01 09:00:40 UTC 
The previous patch was all that was needed to build OOo on W32/bash with the new
mktmp. Committed to vq40.
Comment 3 quetschke 2007-09-01 09:01:46 UTC 
Please verify.
Comment 4 hjs 2007-09-20 11:17:29 UTC 
works as expected
Comment 5 quetschke 2007-09-24 16:19:29 UTC 
This needs to go also into OOo 2.3.1.

Please take over.
Comment 6 hjs 2007-09-25 12:16:05 UTC 
applied patch on cws ause086 with target 2.3.1
Comment 7 hjs 2007-09-25 12:24:24 UTC 
please verify
Comment 8 quetschke 2007-10-08 14:04:15 UTC 
Patch is in ause086 and a full build finished successful -> VERIFIED
Comment 9 rt 2007-10-10 15:54:26 UTC 
Verified on CWS ause086, too.
Comment 10 hjs 2009-02-24 11:51:36 UTC 
.