Issue 80108 - cleanup needed for GetMirroredChar
Summary: cleanup needed for GetMirroredChar
Status: ACCEPTED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 2.3.1
Hardware: All All
: P4 Trivial (vote)
Target Milestone: OOo 3.x
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-27 12:59 UTC by philipp.lohmann
Modified: 2017-05-20 11:31 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description philipp.lohmann 2007-07-27 12:59:01 UTC 
In response to issue 80090 I moved the GetMirroredChar declaration to svapp.hxx
and the sal_UCS4 typedef to vclenum.hxx which in contrast to sallayout.hxx are
delivered.

However since there are more of these plain exported functions in sallaout.hxx
and moreover svapp.hxx and vclenum.hxx are not necessarily the best of places
for this, please move this to somewhere sensible.
Comment 1 hdu@apache.org 2007-08-22 10:32:14 UTC 
VCL's internal GetMirroredChar() shouldn't be used outside vcl. The corresonding method from the I18N framework 
is more appropiate. Also the sal_UCS4/sal_UTF32 typedef shouldn't be exported outside VCL as was agreed with 
the owner of the string classes (http://www.openoffice.org/servlets/ReadMsg?list=interface-discuss&msgNo=753).

Anyway, someone has to revert the changes done for 80090 and fix svx's wrong dependency on VCL internal 
functionality => will do
Comment 2 hdu@apache.org 2007-12-10 16:25:26 UTC 
@er: getting the mirrored unicode belongs into one of the i18n* projects. Since I'm not 
too familiar with the traditions of the three projects i18n, i18nutils and i18npool could 
you please advice where to put it? And which headerfile? 
i18nutil/oneToOneMapping.hxx maybe?
Comment 3 hdu@apache.org 2008-01-14 16:04:07 UTC 
Retargeting, as the issue is not critical in any way.
Comment 4 hdu@apache.org 2009-06-19 14:10:09 UTC 
wrong dependency caused by typo
Comment 5 Marcus 2017-05-20 11:31:25 UTC 
Reset assigne to the default "issues@openoffice.apache.org".