Issue 78832 - Context menu looks different than in native apps
Summary: Context menu looks different than in native apps
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m214
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: eric.savary
QA Contact: issues@porting
URL:
Keywords: aqua
Depends on:
Blocks:
 
Reported: 2007-06-24 08:24 UTC by pavel
Modified: 2008-08-05 12:01 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
combined screenshot of OOo and Terminal context menus (77.02 KB, image/png)
2007-06-24 08:25 UTC, pavel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2007-06-24 08:24:26 UTC
I have taken two screenshots of context menus - one from Ooo and the other from Terminal. There are 
several differences in them.

Compare the border on the right side - there is a black line. Looks like there is some 3d-like border 
around the OOo context menu...

Ismael: are you working on this too? Or is Eric working on context menu?
Comment 1 pavel 2007-06-24 08:25:09 UTC
Created attachment 46208 [details]
combined screenshot of OOo and Terminal context menus
Comment 2 eric.bachard 2007-06-24 18:52:14 UTC
pl added 3D effect for contextual menus, and this is maybe not a good idea to
have different look.

Philipp, what do you think ?

BTW : contextual menus are *not* welcome for UI on Mac OS X :

- too complicated for the user (lot of user don't think/know how to use them)
- useless, because they duplicate the information : nly one place for one feature 
Comment 3 philipp.lohmann 2007-06-25 10:51:15 UTC
We should not draw that additional border, that much is clear. But for context
menus "bad" UI: every application has them, they can't be that bad.
Comment 4 shaunmcdonald131 2007-06-25 11:15:20 UTC
In terms of bad UI. Any feature of the software should be accessible without the context menu. Basically 
some users find it very difficult to use context menus, so you should not force them to use them.
Comment 5 philipp.lohmann 2007-06-25 11:22:30 UTC
So we should fix those places where a feature is available only via context menu
(if there is any), not abandon context menus.
Comment 6 ismaelooo 2007-07-20 11:46:28 UTC
Menus have no more 3D borders but native borders now. There's still a black
pixel on two corners (top right and bottom left ones).

The font used in OOo context menus is not yet the mac menu font. So letting
issue as started.
Comment 7 ericb 2007-09-21 15:03:13 UTC
Is it correct now ?
Comment 8 philipp.lohmann 2007-09-24 10:08:05 UTC
I notice two problems; first there are one or two black pixels on the lower left
of the context menu, then there is a kind of clipping problem when
dehighlighting an item (item text looks clipped a line afterwards).
Comment 9 eric.bachard 2007-09-24 11:05:55 UTC
ericb->pl

About the clipping :

If I have correctly understood, hdu explained me the layouting was done using font metrics, and the 
font metric depends on the resolution.

Maybe I was wrong, but I thought to a (sort of) race between bitmap, font and control metrics. What 
about use the max of height of them to define the control height ? 

And yes, they are probably two issues in one.

Comment 10 eric.bachard 2007-09-24 11:09:33 UTC
removing me from the issue (I receive it twice)
Comment 11 philipp.lohmann 2007-10-16 16:51:38 UTC
the clipping issue is resolved in CWS aquavcl04
Comment 12 pavel 2007-10-18 05:46:09 UTC
pl: confirmed.

So remaining issues:

- black pixel(s) on the bottom-left
- black pixel(s) on the top-right
- the last item in the context menu is not high enough OR there is no space below it (compare with the 
space above the first item)
Comment 13 pavel 2007-10-18 05:47:17 UTC
- the triangle displayed on menu items with submenu is not the same is in other native apps
Comment 14 pavel 2007-10-18 05:49:34 UTC
Small hint:

- the highlight on selected item is not aligned with the border of the context menu

Maybe this is the reason for the black pixels in bottom-left.
Comment 15 philipp.lohmann 2008-04-29 14:20:48 UTC
pl->fne: you're working on native context menus, that should fix this.
Comment 16 cobour 2008-05-08 13:28:24 UTC
implemented in aquavcl07
Comment 17 philipp.lohmann 2008-05-13 19:19:00 UTC
please verify in CWS aquavcl07
Comment 18 eric.savary 2008-05-26 15:42:56 UTC
Verified in CWS aquavcl07
Comment 19 Raphael Bircher 2008-08-05 12:01:37 UTC
fixed in master

closing issue