Issue 75016 - New Chart: Open unknown file type and press Cancel => Crash
Summary: New Chart: Open unknown file type and press Cancel => Crash
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 680m202
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@sw
URL:
Keywords: new_implementation
Depends on:
Blocks:
 
Reported: 2007-03-01 12:24 UTC by bjoern.milcke
Modified: 2013-08-07 14:42 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.milcke 2007-03-01 12:24:42 UTC 
Appears in chart2mst3 Milestone 11 build:

1. Try to open a file of unknown type, e.g. a pdf-file.
=> A dialog pops up that offers some choices for ASCII-Text formats (and
obviously a Writer is created in the background)
2. Press Cancel
=> Crash in SwDocShell DTOR

In sw/source/ui/app/docshini.cxx in the DTOR of the SwDocShell (line 549)
GetDoc() returns a NULL-pointer which is accessed unchecked.
Note that in the line below "pDoc" is used, which is probably the same variable
(it is also NULL) that is returned by GetDoc(). Of course both places must be
checked.

-> TL: Please check if it is sufficient to check for the NULL-ness of the
pointer, or anything else is needed (and fix it ;-) )
Comment 1 bjoern.milcke 2007-03-01 12:36:21 UTC 
Ok, taking back. Fixed together at my place. A pointer check seems sufficient.
Comment 2 bjoern.milcke 2007-03-01 12:37:50 UTC 
Fixed in chart2mst3 (after mst 11)
Comment 3 IngridvdM 2007-03-01 20:14:17 UTC 
set keyword and changed issue type to reflect that this issue did only occur in
the new chart and did not affect the current product on the master branch
Comment 4 bjoern.milcke 2007-03-02 09:52:26 UTC 
Fixed in chart2mst3 Milestone 11_1.
Comment 5 kla 2007-03-05 13:19:46 UTC 
No crach anymore -> verified in mst 11_1
Comment 6 p9w.vu.31122010 2007-07-17 16:30:43 UTC 
Verified fixed in m221