Issue 73139 - testtool crashes because of wrong delete order
Summary: testtool crashes because of wrong delete order
Status: CLOSED DUPLICATE of issue 49665
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: OOo 2.1
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: gregor.hartmann
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-04 18:37 UTC by pmladek
Modified: 2007-06-20 09:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed fix of the crash (406 bytes, patch)
2007-01-04 18:38 UTC, pmladek 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pmladek 2007-01-04 18:37:49 UTC 
I have investigated a crash of testtool. It was caused by a wrong order of
delete commands. pImpl was deleted before pImpl->pChildEnv. It is fixed by the 
attached patch.

BTW: When I investigated the code, I found that the following variables were
allocated in the constructor but not deleted in the destructor. Is it OK?

    pImpl->xErrorList
    pImpl->xWarningList
    pImpl->xQAErrorList
    pImpl->xIncludeFileWarningList
Comment 1 pmladek 2007-01-04 18:38:57 UTC 
Created attachment 41885 [details]
Proposed fix of the crash
Comment 2 gregor.hartmann 2007-01-05 10:09:36 UTC 
too bad you didn't find it earlier as the original bug was files on linux PPC
which was kind of impossible for me to reproduce. Stumbled across it by accident.

But will add the other changes in CWS GH13


*** This issue has been marked as a duplicate of 49665 ***
Comment 3 jjmckenzie 2007-01-06 10:46:53 UTC 
Patch not moved to original issue.  

This may solve crashes on startup in the MacOSX Intel version (69378). 
Incorporating patch into ongoing test builds.

James McKenzie
Comment 4 kendy 2007-06-20 09:44:19 UTC 
Closing.