Apache OpenOffice (AOO) Bugzilla – Issue 72804
Border dialog preview incorrect for RTL
Last modified: 2017-05-20 11:18:03 UTC
When an RTL user defines borders in the border dialog, the table preview does not reflect the table in the document. Changing the left border in the preview will change the *right* border in the table and vice versa. Note in the screenshot that removing the right border in the dialog actually removes the left border in the document. I'm attaching a patch to fix this. Please review. Thanks.
Created attachment 41598 [details] Screenshot illustrating the problem
Created attachment 41599 [details] Proposed patch
Reassigned to OS. The control for setting borders does not respect RTL mode in a document.
Alan, do you need more help? Are you still interested?
->mba: I sent a patch in December when I first submitted the issue. Has anyone reviewed it?
Sorry, Alan, I mis-read the comment from mru. Of course now the ball is in our field. :-[ Thanks for your patch, my fault. As Oliver is very busy I think Peter can take over. If the patch is fine we should be able to integrate it into 2.3. So I changed the target accordingly.
My patch needs to be fixed. The patch does cause the correct border to get changed in the document, but if the table properties dialog is reopened, the preview shows the wrong border as modified.
pb: I take over.
pb: Sorry Alan, but I cannot reproduce this problem. With an arabic version or an english version (and SAL_RTL_ENABLED=1) the right border is changed.
ayaniger->pb: Setting SAL_RTL_ENABLED won't reproduce the problem. You have to set the locale to a CTL language like Hebrew or Arabic. I just reproduced the problem on a fresh install of the distributed 2.2 on Debian Linux.
pb: Sorry, yes you are right. It is necessary that the text direction is Right-to-Left to occur this bug. So I will have a look on your patch.
pb: the patch only works if RTL-Layout is set and the textdirection is set to RTL too. But it doesn't work if RTL-Layout isn't set and textdirection is set to RTL and it fails if RTL-Layout is set and the textdirection is set to LTR. So I have to reject your patch. Sorry.
ayaniger->pb: Yes, I already wrote in an earlier post to this issue that my patch doesn't work. I should have changed to issue type back to defect. I'll do that now.
Move target because of inactivity and code freeze.
move target to 3.x
Still happens in OpenOffice.org 3.2.1 OOO320m19 (Build:9505). Could we get a target for this one ?
Reproducible in OpenOffice.org 3.3 OOO330m3.
Almost exactly the same as http://www.openoffice.org/issues/show_bug.cgi?id=114969 Only that one is in calc.
Reset assigne to the default "issues@openoffice.apache.org".