Issue 71051 - m191: [mM]akefile is not present in soltools
Summary: m191: [mM]akefile is not present in soltools
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Mac OS X, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.1
Assignee: rt
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-31 21:06 UTC by pavel
Modified: 2006-11-07 08:47 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Use size_t for read n_bytes argument (644 bytes, patch)
2006-11-01 09:57 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-10-31 21:06:35 UTC
Hi,

current to-be-m191 on Mac OS X:

...
-rwxr-xr-x   1 oo  oo  54184 Oct 31 21:40 ../unxmacxp.pro/bin/makedepend
-------------
/Volumes/Build/oo/BuildDir/ooo_SRC680_m191_src/soltools/support
../unxmacxp.pro/bin/makedepend @/tmp/mkpVjG1s >
../unxmacxp.pro/misc/all_soltools_support.dpslo
../unxmacxp.pro/bin/makedepend: error:  [mM]akefile is not present
dmake:  Error code 1, while making '../unxmacxp.pro/misc/all_soltools_support.dpslo'
dmake:  '../unxmacxp.pro/misc/all_soltools_support.dpslo' removed.
'---* TG_SLO.MK *---'

ERROR: Error 0 occurred while making
/Volumes/Build/oo/BuildDir/ooo_SRC680_m191_src/soltools/support
Comment 1 pavel 2006-10-31 21:38:22 UTC
works OK on unxlngi6 though. Hmm ;-)
Comment 2 pavel 2006-11-01 05:44:53 UTC
The same problem now with final m191.

m190 was OK on both systems.
Comment 3 pavel 2006-11-01 09:45:52 UTC
So:

In the output from fstat:

         off_t    st_size;   /* file size, in bytes */

and it is given to read as nbytes:

     read(int d, void *buf, size_t nbytes);

size of off_t is 8 (__int64_t)
size of size_t is 4 (unsigned long)

;-)

BUT I wonder why it failed just now, in m191 and not earlier!
Comment 4 pavel 2006-11-01 09:57:08 UTC
Created attachment 40214 [details]
Use size_t for read n_bytes argument
Comment 5 pavel 2006-11-02 08:02:59 UTC
rt: can you please masterfix it?

This problem affects only Mac OS X/PPC because of the different sizes of these
types.

Verified on other systems as well.
Comment 6 rt 2006-11-02 08:24:16 UTC
Patch looks safe and I can apply it as masterfix, yes. But just for curiosity:
how can this size_t-stuff cause an error message as '[mM]akefile is not present'?
Comment 7 pavel 2006-11-02 08:29:35 UTC
The easiest description is this one:

macmini:~/q oo$ cat q.c
#include <stdio.h>
#include <sys/types.h>

int main(int argc, char **argv) {
   off_t size = 776;
   printf("size is %d\n", size);
   printf("size is %lld\n", size);
}
macmini:~/q oo$ gcc q.c 
macmini:~/q oo$ ./a.out 
size is 0
size is 776
macmini:~/q oo$ 

-> the file "was" 0 bytes long so no arguments to makedepend were extracted from it.
Comment 8 rt 2006-11-02 08:30:32 UTC
Do we need this fixed for SRC680 (will be m192) only or does it also effect OOE680?
Comment 9 pavel 2006-11-02 08:32:14 UTC
This problem was uncovered by ause060, so only SRC680 is affected.
Thanks.
Comment 10 rt 2006-11-02 09:13:24 UTC
Patch applied and committed as master fix for upcoming SRC680 m192.
Comment 11 rt 2006-11-07 08:47:26 UTC
closing