Apache OpenOffice (AOO) Bugzilla – Issue 71051
m191: [mM]akefile is not present in soltools
Last modified: 2006-11-07 08:47:26 UTC
Hi, current to-be-m191 on Mac OS X: ... -rwxr-xr-x 1 oo oo 54184 Oct 31 21:40 ../unxmacxp.pro/bin/makedepend ------------- /Volumes/Build/oo/BuildDir/ooo_SRC680_m191_src/soltools/support ../unxmacxp.pro/bin/makedepend @/tmp/mkpVjG1s > ../unxmacxp.pro/misc/all_soltools_support.dpslo ../unxmacxp.pro/bin/makedepend: error: [mM]akefile is not present dmake: Error code 1, while making '../unxmacxp.pro/misc/all_soltools_support.dpslo' dmake: '../unxmacxp.pro/misc/all_soltools_support.dpslo' removed. '---* TG_SLO.MK *---' ERROR: Error 0 occurred while making /Volumes/Build/oo/BuildDir/ooo_SRC680_m191_src/soltools/support
works OK on unxlngi6 though. Hmm ;-)
The same problem now with final m191. m190 was OK on both systems.
So: In the output from fstat: off_t st_size; /* file size, in bytes */ and it is given to read as nbytes: read(int d, void *buf, size_t nbytes); size of off_t is 8 (__int64_t) size of size_t is 4 (unsigned long) ;-) BUT I wonder why it failed just now, in m191 and not earlier!
Created attachment 40214 [details] Use size_t for read n_bytes argument
rt: can you please masterfix it? This problem affects only Mac OS X/PPC because of the different sizes of these types. Verified on other systems as well.
Patch looks safe and I can apply it as masterfix, yes. But just for curiosity: how can this size_t-stuff cause an error message as '[mM]akefile is not present'?
The easiest description is this one: macmini:~/q oo$ cat q.c #include <stdio.h> #include <sys/types.h> int main(int argc, char **argv) { off_t size = 776; printf("size is %d\n", size); printf("size is %lld\n", size); } macmini:~/q oo$ gcc q.c macmini:~/q oo$ ./a.out size is 0 size is 776 macmini:~/q oo$ -> the file "was" 0 bytes long so no arguments to makedepend were extracted from it.
Do we need this fixed for SRC680 (will be m192) only or does it also effect OOE680?
This problem was uncovered by ause060, so only SRC680 is affected. Thanks.
Patch applied and committed as master fix for upcoming SRC680 m192.
closing