Issue 71027 - WaE on Mac OS X: multiple modules
Summary: WaE on Mac OS X: multiple modules
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: DevTools
Assignee: pavel
QA Contact: issues@porting
URL:
Keywords:
: 68450 (view as issue list)
Depends on:
Blocks:
 
Reported: 2006-10-31 09:11 UTC by pavel
Modified: 2007-11-23 13:59 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-10-31 09:11:30 UTC 
Hi,

I'm now cleaning the list of modules that disable WaE on Mac OS X. There are
several patches I accumulated so far:

http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE/

I won't touch this directory during the review. If you need to ask something,
I'm on IRC.

I plan to commit approved patches to pj65 where I did the first part.
Comment 1 Stephan Bergmann 2006-10-31 12:15:23 UTC 
Three notes:

1 iFIXME-i18npool.diff:  Should better read
---8<---
         {
 #ifdef MACOSX
             rtl_Locale    *procLocale;
+            (void) pGetLangFromEnv; /* unused */
 
             if ( osl_getProcessLocale(&procLocale) == osl_Process_E_None )
             {
---8<---

2 iFIXME-testtools.diff: Please consistently use either pattern
  T x = T();
or
  T x = 0;
in a single area of code.

3 iFIXME-xmlscript.diff: Please use
  sal_Bool x = sal_False;
instead of
  sal_Bool x = 0;
Comment 2 pavel 2006-10-31 12:21:33 UTC 
Yup, will do.

Thank for very fast review!
Comment 3 pavel 2006-11-04 22:51:17 UTC 
Four new patches at http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE-1/:

http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE-1/iFIXME-basic.diff

New change in basic in to-be-m192. It will error for HBG builds as well -
#i71175# now.

http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE-1/iFIXME-svtools.diff

Simple.

http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE-1/iFIXME-sfx2.diff

Complete sfx2 diff - simple "= 0" changes.

http://tmp.janik.cz/OpenOffice.org/MacOSX/WaE-1/iFIXME-svx.diff

Complete svx diff. Simple changes.
In one case, I had to comment out #include <rope> because it was not needed and
caused warning (svx/source/dialog/plfilter.cxx).
Comment 4 Stephan Bergmann 2006-11-06 09:03:21 UTC 
1  Yes, iFIXME-basic.diff is a duplicate of issue 71175 (which IMO fixes the
problem subotimally, by commenting out instead of removing completely).

2  iFIXME-svx.diff, ooo_SRC680_m191_src/svx/source/dialog/plfilter.cxx:  Please
remove the spurious #include <rope> completely (see 1).

3  iFIXME-svx.diff, ooo_SRC680_m191_src/svx/source/msfilter/escherex.cxx, @@
-2404,8 +2404,9 @@ introduces spurious vertical white space.
Comment 5 pavel 2006-11-06 12:39:20 UTC 
OK, done in pj65.
Comment 6 Stephan Bergmann 2006-11-15 08:23:21 UTC 
verified by code review
Comment 7 pavel 2006-12-06 12:56:07 UTC 
.
Comment 8 andreas.martens 2007-11-23 13:59:47 UTC 
*** Issue 68450 has been marked as a duplicate of this issue. ***