Issue 69774 - make_installer.pl glitch with multi-language installer and Cygwin md5sum
Summary: make_installer.pl glitch with multi-language installer and Cygwin md5sum
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: current
Hardware: PC Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 2.2
Assignee: ingo.schmidt-rosbiegal
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-22 12:27 UTC by tml
Modified: 2007-01-04 16:48 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description tml 2006-09-22 12:27:38 UTC
In make_installer.pl is the code:

	my $loglanguagestring_orig = $loglanguagestring;
	if (length($loglanguagestring) > 120)
	{
	    chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/  -//g"`);
	    $loglanguagestring = $shorter;
	}

As such I don't understand what's so magic with the length 120, but anyway, the
problem on a Cygwin-based build is that the md5sum output looks like:

04d214ac94b0d2f46c621ac6bd6cc8b1 *-

Note just one space and an asterisk after the hex digits. Thus the sed command
fails to remove them.

Trivial fix:

--- solenv/bin/make_installer.pl
+++ solenv/bin/make_installer.pl
@@ -549,7 +549,7 @@
 	my $loglanguagestring_orig = $loglanguagestring;
 	if (length($loglanguagestring) > 120)
 	{
-	    chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/  -//g"`);
+	    chomp(my $shorter = `echo $loglanguagestring | md5sum | sed -e "s/ .*//g"`);
 	    $loglanguagestring = $shorter;
 	}
 

Of course, the Perl way would be to use Digest::MD5's md5_hex() function for
this instead of running three external programs, but I digress...

After fixing this there are still other problems that pop up if one includes
"too many" languages in a multi-language installer, but I'll open separate
issues for those once I have investigated further.
Comment 1 rt 2006-10-25 13:15:19 UTC
Ingo, I guess this is something for you.
Comment 2 ingo.schmidt-rosbiegal 2006-10-27 10:57:18 UTC
Yes, a simple fix. Try to find a cws for 2.1 .
Comment 3 ingo.schmidt-rosbiegal 2006-10-27 13:05:43 UTC
Setting taret 2.2, perhaps 2.1 is still possible.
Comment 4 ingo.schmidt-rosbiegal 2006-10-27 13:25:50 UTC
Accepted
Comment 5 ingo.schmidt-rosbiegal 2006-11-14 10:07:50 UTC
Fixed in cws native72
Comment 6 ingo.schmidt-rosbiegal 2006-12-14 14:45:55 UTC
Verified in cws native72.
Comment 7 ingo.schmidt-rosbiegal 2007-01-04 16:48:14 UTC
Integrated in m198. Closing issue.