Issue 69592 - obo05: VSE build breaks in icu
Summary: obo05: VSE build breaks in icu
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows, all
: P2 Trivial (vote)
Target Milestone: OOo 2.1
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-16 18:28 UTC by quetschke
Modified: 2006-11-01 18:30 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-16 18:28:04 UTC 
The VSE build breaks in icu with:

mkdir.pl ./wntmsci11.pro/misc/build/icu/source
cd ./wntmsci11.pro/misc/build/icu/source && cd allinone/all && cmd /c nmake /f
all.mak CFG="all - Win32 Release" "EXCEPTIONSWITCH=""-EHa -Zc:wchar_t-"" && cd
../..  && /bin/touch.exe
/cygdrive/d/w1/tin_obo05/icu/./wntmsci11.pro/misc/build/so_built_so_icu
/bin/bash: -c: line 0: unexpected EOF while looking for matching `"'
/bin/bash: -c: line 1: syntax error: unexpected end of file
dmake:  Error code 2, while making './wntmsci11.pro/misc/build/so_built_so_icu'

Obvious patch: "" -> $(EMQ)""
Comment 1 quetschke 2006-09-16 18:30:01 UTC 
Committed to obo05.

Please verify.
Comment 2 oliver.bolte 2006-09-19 09:56:12 UTC 
I've commited makefile.mk and makefiles.zip. It works for 4nt and hopefully
w32-bash shell.
Comment 3 oliver.bolte 2006-09-19 10:08:22 UTC 
Hi Volker,
my change works for 4nt. Does it also work with w32-bash?
verify please.
Comment 4 quetschke 2006-09-19 13:49:15 UTC 
I'll try once my build is ready. Did my change fail for you? I wonder because
$(EMQ) is <empty> for 4NT builds, so it should have worked for all shell flavors.
Comment 5 oliver.bolte 2006-09-19 14:01:28 UTC 
Hi Volker,

I'm also wondering, but yes it has broken the 4nt build. I've move one quoting
into all.mak inside makefiles.zip its hopefully less sensitive (icu 2.6 will be
replaced by 3.6 soon and I'll insert your change there too)

Oliver
Comment 6 quetschke 2006-09-19 14:49:56 UTC 
Uhh, I don't understand this quoting anymore ;)

With this:
CFG="all - Win32 Release" EXCEPTIONSWITCH=$(EMQ)"-EHa -Zc:wchar_t-$(EMQ)"

the $(EMQ) is propably not needed - I'll figure that out.
Comment 7 quetschke 2006-09-19 15:29:36 UTC 
I had to remove the $(EMQ)s again. Works for me with that (committed) change.

VERIFIED
Comment 8 oliver.bolte 2006-09-21 10:56:44 UTC 
Hi Volker,

many thanks. I've also made the changes for icu 3.6 (without $(EMQ)).

Oliver
Comment 9 quetschke 2006-11-01 18:30:31 UTC 
close