Issue 69563 - W32-bash: obo05 failes in soltools/mkdepend
Summary: W32-bash: obo05 failes in soltools/mkdepend
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: PC Windows, all
: P1 (highest) Trivial (vote)
Target Milestone: OOo 2.1
Assignee: oliver.bolte
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-15 13:41 UTC by quetschke
Modified: 2006-09-29 14:17 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch to quote ; for bash/tcsh (22.78 KB, patch)
2006-09-15 16:53 UTC, quetschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2006-09-15 13:41:56 UTC
Note, this is a .NET 2003 build, not using VS Express.

The build failes with:

-------------
pr.c
d:\w1\tin_obo05\soltools\mkdepend\def.h(157) : warning C4668:
'NeedVarargsPrototypes' is not defined as a preprocessor macro, replacing with
'0' for '#if/#elif'
pr.c(43) : warning C4131: 'add_include' : uses old-style declarator
pr.c(59) : warning C4013: 'warning' undefined; assuming extern returning int
pr.c(63) : warning C4013: 'warning1' undefined; assuming extern returning int
pr.c(73) : warning C4013: 'included_by' undefined; assuming extern returning int
pr.c(79) : warning C4013: 'find_includes' undefined; assuming extern returning int
pr.c(80) : warning C4013: 'freefile' undefined; assuming extern returning int
pr.c(86) : warning C4131: 'recursive_pr_include' : uses old-style declarator
pr.c(101) : warning C4131: 'pr' : uses old-style declarator
guw.pl link /COMMENT:"soltools_680__"  /MACHINE:IX86 @/tmp/mkLSBX9M
if test -f ../wntmsci10.pro/bin/makedepend.exe.manifest ; then mt.exe -manifest
../wntmsci10.pro/bin/makedepend.exe.manifest
-outputresource:../wntmsci10.pro/bin/makedepend.exe;1
------------------------------
Making: ../wntmsci10.pro/bin/makedepend.exe
Microsoft (R) Incremental Linker Version 7.10.3077
Copyright (C) Microsoft Corporation.  All rights reserved.

/MAP /OPT:NOREF /NODEFAULTLIB /RELEASE /DEBUG:full /SUBSYSTEM:CONSOLE
/BASE:0x1b000000 -out:../wntmsci10.pro/bin/makedepend.exe
-map:../wntmsci10.pro/misc/makedepend.map ..\wntmsci10.pro\obj\cppsetup.obj
..\wntmsci10.pro\obj\ifparser.obj ..\wntmsci10.pro\obj\include.obj
..\wntmsci10.pro\obj\main.obj ..\wntmsci10.pro\obj\parse.obj
..\wntmsci10.pro\obj\pr.obj msvcrt.lib kernel32.lib user32.lib oldnames.lib 
linking ../wntmsci10.pro/bin/makedepend.exe.manifest ...
/bin/bash: -c: line 1: syntax error: unexpected end of file
dmake:  Error code 2, while making '../wntmsci10.pro/bin/makedepend.exe'
dmake:  '../wntmsci10.pro/bin/makedepend.exe' removed.

ERROR: Error 65280 occurred while making /cygdrive/d/w1/tin_obo05/soltools/mkdepend


The ";1" in the "if test ..." line looks suspicious, that should have been a ;fi
Comment 1 oliver.bolte 2006-09-15 14:15:02 UTC
Hmm, the ;1 is ok it tells the mt the resource type. With 4nt shell it works for
wntmsci10 and wntmsci11.
Comment 2 oliver.bolte 2006-09-15 14:33:34 UTC
I've commited the corrected versions in solenv/inc (tg_app.mk, _tg_app.mk,
tg_shl.mk, _tg_shl.mk)
Comment 3 quetschke 2006-09-15 16:15:05 UTC
Thanks for the quick fix, but I sure that will still fail. :(

bash/tcsh will complain about the ';'

$ echo aaa;bbb
aaa
bash: bbb: command not found

The fix is (I'll commit it if you don't beat me to it) to replace ;
with $(EMQ);
Comment 4 quetschke 2006-09-15 16:53:42 UTC
Created attachment 39170 [details]
Patch to quote ; for bash/tcsh
Comment 5 quetschke 2006-09-15 16:56:29 UTC
Committed.

I'm also worried about not using $(WRAPCMD) in front of mt.exe, but I'll only
add that if it poses a problem.
Comment 6 quetschke 2006-09-18 04:50:07 UTC
No further problem with this issue.

Please verify.
Comment 7 oliver.bolte 2006-09-18 11:39:40 UTC
verified.
Comment 8 oliver.bolte 2006-09-29 14:17:27 UTC
closed.